Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Delivered status for sent and delivered messages in group chats #20126

Closed
mariia-skrypnyk opened this issue May 21, 2024 · 5 comments
Closed

Comments

@mariia-skrypnyk
Copy link

Bug Report

Reproduction

  1. Install app
  2. Create a group chat or use the existing one
  3. Send any text message
  4. Wait for some time to see the Delivered status

Expected behavior

Delivered message appears right after Sent when message is really delivered

Actual behavior

No Delivered status. Only Sent status is present.
Screenshot 2024-05-21 at 11 04 29

Additional Information

  • Status version: nightly 21/05
  • Operating System: Android, iOS
@cammellos cammellos added this to the 2.29.0 Beta milestone May 23, 2024
@vitvly vitvly self-assigned this May 23, 2024
@cammellos cammellos moved this to Code review in Status Desktop/Mobile Board May 23, 2024
@cammellos cammellos moved this from Code review to In Progress in Status Desktop/Mobile Board May 23, 2024
@vitvly
Copy link
Contributor

vitvly commented May 30, 2024

Some findings:

  1. Have been investigating the message delivery flow, added unit tests and logs to verify in https://github.com/status-im/status-go/tree/fix/group-chat-message-delivery.
  2. Could be that Extend peersyncing to sync 1-to-1 messages status-go#4962 is related
  3. Trying to ascertain it via testing against different status-go versions.

@vitvly
Copy link
Contributor

vitvly commented May 30, 2024

Having finally resolved ios build issues, was able to verify 2 and 3 - it's a different status-go issue. Continuing debug.

@vitvly
Copy link
Contributor

vitvly commented May 31, 2024

Not reproducible in latest develop, after pulling the latest changes from yesterday.

@vitvly
Copy link
Contributor

vitvly commented May 31, 2024

Just verified that it is this commit that fixed delivery status for group chats: status-im/status-go@0061c56

@vitvly
Copy link
Contributor

vitvly commented May 31, 2024

Fixed with #20255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants