-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: point to recovery account fix in status-go #18110
Conversation
@siddarthkay thank you for creating mobile PR! I am on it. |
Jenkins Builds
|
63% of end-end tests have passed
Failed tests (12)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (6)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Passed tests (31)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestDeepLinksOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
|
@IvanBelyakoff thank you for the fix. The issue is still reproducible for me in case of recovering user with tokens. ISSUE 1 App crashes after recover of user with tokensSteps:
Actual result: raw_logcat.log.zip telegram-cloud-document-2-5445149560659787548.mp4 |
Got it. Ok, i will have a look at it now one more time. I think I tested on an empty account. Will make a quick fix for you and then add a test for it |
@pavloburykh So this is another crash from what I fixed. I am not sure why this crash appeared because as I see we never (or if it happened, then long ago) sent a block number with RecentHistoryReady event, but that case was not handled in local notification service. I don't think it makes sense to send any block number with this event. |
794d72f
to
797923c
Compare
69% of end-end tests have passed
Failed tests (8)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (7)Click to expandClass TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (34)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
@IvanBelyakoff thank you for the fix. Tested manually and no crash is detected. Failed e2e either known or related to global data delivery issues. Ready for merge. |
fixed in status-go and included in version |
@status-im/mobile-qa
PR to test status-go fix.
fixes #18092
status: ready