Fix/tokens block range nil access

[IvanBelyakoff]

On empty acc access to a nil pointer is fixed
Fixed a crash on a nil block number in local notification service on HistoryReady event

[status-im-auto]

Jenkins Builds

Click to see older builds (8)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	6911c11	#1	2023-12-07 07:17:30	~3 min	linux	📦zip
✔️	6911c11	#1	2023-12-07 07:18:42	~5 min	ios	📦zip
✔️	6911c11	#1	2023-12-07 07:19:13	~5 min	android	📦aar
✔️	6911c11	#1	2023-12-07 07:49:07	~35 min	tests	📄log
✔️	e3b2b3a	#2	2023-12-07 07:25:04	~1 min	linux	📦zip
✔️	e3b2b3a	#2	2023-12-07 07:25:45	~2 min	android	📦aar
✔️	e3b2b3a	#2	2023-12-07 07:26:32	~3 min	ios	📦zip
✖️	e3b2b3a	#2	2023-12-07 08:22:07	~32 min	tests	📄log

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✖️	157a952	#3	2023-12-07 11:18:30	~1 min	tests	📄log
✔️	157a952	#3	2023-12-07 11:19:17	~1 min	android	📦aar
✔️	157a952	#3	2023-12-07 11:20:33	~3 min	linux	📦zip
✔️	157a952	#3	2023-12-07 11:20:38	~3 min	ios	📦zip
✔️	b869cd5	#4	2023-12-07 11:33:37	~1 min	linux	📦zip
✔️	b869cd5	#4	2023-12-07 11:37:03	~5 min	ios	📦zip
✖️	b869cd5	#4	2023-12-07 11:37:12	~5 min	tests	📄log
✔️	b869cd5	#4	2023-12-07 11:38:14	~6 min	android	📦aar
✖️	b869cd5	#5	2023-12-07 11:55:02	~2 min	tests	📄log
✖️	b869cd5	#6	2023-12-07 13:10:05	~4 min	tests	📄log
✔️	b869cd5	#7	2023-12-07 13:45:38	~32 min	tests	📄log

[siddarthkay]

@IvanBelyakoff : do you mind if we verify this fix with a PR in mobile repo?
I can create that PR.

cc @cammellos @churik

[IvanBelyakoff]

@IvanBelyakoff : do you mind if we verify this fix with a PR in mobile repo? I can create that PR.

cc @cammellos @churik

sure go ahead

[siddarthkay]

@IvanBelyakoff : Thanks a lot for the swift fix :) we'll run E2E suite here status-im/status-mobile#18110

[IvanBelyakoff]

@cammellos I treated NoRows as no error when getting wallet preferences. Is it ok with you? Could you please have a look

[churik]

@IvanBelyakoff can you please take a look to not successful checks before we take PR to test again?
Thanks!

[IvanBelyakoff]

@IvanBelyakoff can you please take a look to not successful checks before we take PR to test again? Thanks!

I believe the tests failure is not related to my PR, the tests pass successfully locally on my PC. I will restart them several times until they pass, but if you wan tto test it, I don't think you need to wait for them to pass

[churik]

@siddarthkay can you please update status-go in our status-mobile Pr?

[siddarthkay]

@siddarthkay can you please update status-go in our status-mobile Pr?

updated a while ago, confirmed that current status-go commit hash match our status-go-version.json

[siddarthkay]

Lets go! 🚀

[pavloburykh]

@IvanBelyakoff thank you for the fix. Tested manually and no crash is detected. Failed e2e either known or related to global data delivery issues. Ready for merge.