-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] test fix for #16693 #16729
[WIP] test fix for #16693 #16729
Conversation
Jenkins BuildsClick to see older builds (4)
|
020e3ea
to
4861264
Compare
4861264
to
2a10df3
Compare
90% of end-end tests have passed
Failed tests (4)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (36)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
Hey @Parveshdhull, here is a short summary of what happened during this time with the issue: Yesterday, for some reason, the issue began to reproduce both in PR and nightly, manually on physical devices and e2e. It was reproduced with the following steps in e2e and manually (some of the steps may of course be redundant, but I could not cut it off, since it was not reproduced every time again):
But that's no longer reproducible today, so I cannot compare it with today's nightly. |
88% of end-end tests have passed
Failed tests (5)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Passed tests (35)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
|
Hi @qoqobolo,
The fact that it was reproducible in the PR even before rebase, tells that the current fix is not working and layout animations are not the culprit.
So, now the issue is also not reproducible in the previous nightly too? (or only today) Anyway, looks like we are not sure about the issue's cause, and the current fix is not working, so closing this PR. |
100% of end-end tests have passed
Passed tests (1)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
|
Oops, sorry, I wrote it a bit inaccurately. The issue was reproducible yesterday in other PRs and in nightly. In this PR, I could not reproduce it even once, before or after.
So, today the issue is not reproducible anywhere, but yesterday I reproduced it in nightly several times. |
status: just small testing for #16693