Elements overlap each other on Android (profile selection page; chat view)

[qoqobolo]

Bug Report

Problem

Reproduction

We were able to reproduce these scenarios:

1.

1. Create several accounts
2. Add at least one community to each of them
3. Log out
4. Open the profile selection page

At some point the cards start overlaying each other

2.

1. Create a profile, create a community
2. Log out
3. Create another profile, join a community

3.

Preconditions: at least 1 profile is already created

1. Create one more fresh profile - User A
2. UserA: send CR to UserB
3. UserB: accept CR
4. UserA: log out right after User B accepts CR
5. Open the profile selection screen by User A

Additional Information

• Status version: RC
• Operating System: Android

[Parveshdhull]

Hi @qoqobolo, Are you able to reproduce this issue on multiple Android devices?

[qoqobolo]

Hi @qoqobolo, Are you able to reproduce this issue on multiple Android devices?

Yes, we reproduced this on at least Pixel, Huawei and Samsung

[Parveshdhull]

Hi @qoqobolo, Are you able to reproduce this issue on multiple Android devices?

Yes, we reproduced this on at least Pixel, Huawei and Samsung

Thank you for confirming

[Parveshdhull]

(defn view
  []
  (let [show-profiles?    (reagent/atom false)
        set-show-profiles #(reset! show-profiles? true)
        set-hide-profiles #(reset! show-profiles? false)]
    (fn []
      [:<>
       [background/view true]
       (if @show-profiles?
         [profiles-section {:set-hide-profiles set-hide-profiles}]
         [login-section {:set-show-profiles set-show-profiles}])])))

Profile screen is controlled by a regent atom and only one view should be visible at a time. Don't know why both are visible. Maybe you have some idea @flexsurfer

Both profiles and chat screens force updates view at runtime, and removes old view and renders new one
First using reframe subscription and second using reagent atom. But for some reason old view is not getting removed and both views getting rendered simultaneously 🤔

[Parveshdhull]

@qoqobolo, I tried creating several accounts with communities and navigating to profiles, but I am not able to reproduce the issue.
Please can you confirm the frequency of occurrence, if it is quite rare and non-blocker, Please can we move this to the next release?

[Parveshdhull]

Don't know why they are visible both

In #16433 we implemented layout animation, so if a toast is shown it enables them. Just a guess, but that might be breaking layout while animating it.

Because once enabled, it starts to affect other places too: #14752

[Parveshdhull]

Should I create a pr for disabling layout animations for QA, to check if it fixes the issue?

[qoqobolo]

@qoqobolo, I tried creating several accounts with communities and navigating to profiles, but I am not able to reproduce the issue.
Please can you confirm the frequency of occurrence, if it is quite rare and non-blocker, Please can we move this to the next release?

Thank you very much for investigating the issue!
It's quite severe and also occurs in other places (screens) of the app, but it's really not that easy to reproduce, and since we don't have a simple and quick solution, let's move it to 1.25 👍

Should I create a pr for disabling layout animations for QA, to check if it fixes the issue?

Yes, please do this so we can test the hypothesis after testing the release.

[Parveshdhull]

Yes, please do this so we can test the hypothesis after testing the release.

Sounds good, thank you very much

[Parveshdhull]

Hi @qoqobolo, I created a pr with disabled layout animations. Whenever you have some spare time, please give it a try and let me know if the issue is still reproducible for you. Thank you very much for looking into this issue.

#16729

[qoqobolo]

thank you @Parveshdhull, we will check!
Added the request-manual-qa label just for better visibility.

[qoqobolo]

Reopening the issue since it's reproducible again.
Device: Pixel 7a

Steps:

1. Create a profile
2. Log out from the profile screen
3. Quickly tap the Profiles button (at the top right)

Sometimes you need to repeat this a couple of times.

video_2023-08-31_10-37-15.mp4

[qoqobolo]

Unable to reproduce it again.

[pavloburykh]

@Parveshdhull unfortunately still reproducible, so reopening the issue. Steps are yet unknown.

Reproduced on Android 12, Samsung Galaxy A52
Build nightly (21 Sep, 2023)

Status-debug-logs (63).zip

telegram-cloud-document-2-5215358463747569775.mp4

[Parveshdhull]

It looks like issue is most probably with reanimated library version and will be fixed in reanimated v3. More info #16832

[churik]

closing this for now, reopen if reproducible