IOS only upgrade react-native to 0.72.x #16721
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddarthkay
commented
Jul 19, 2023
| @@ -49,12 +47,7 @@ stdenv.mkDerivation { | |||
| ${patchMavenSources} $modBuildGradle | |||
| done | |||
| ''; | |||
| # Do not add a BuildId to the generated libraries, for reproducibility | |||
| patchBuildIdPhase = '' | |||
| substituteInPlace ./node_modules/react-native/ReactAndroid/src/main/jni/Application.mk --replace \ | |||
There was a problem hiding this comment.
now that ReactAndroid/src/main/jni/Application.mk no longer exists, We'll have to figure out where to update build-id :)
Jenkins BuildsClick to see older builds (39)
|
siddarthkay
force-pushed
the
upgrade/ios-only-rn-0.72.x
branch
from
2697a53
to
5f2df4a
Compare
siddarthkay
force-pushed
the
upgrade/ios-only-rn-0.72.x
branch
2 times, most recently
from
f32b958
to
1836485
Compare
|
Hit a blocker at Although builds are green at the moment but the app indefinitely stays on the splash screen and when you put the app in background and open it again you are greeted with this not so specific error.
My current hypothesis is that I need to more thoroughly clean up all of the v1 usage of More updates on this later. |
siddarthkay
force-pushed
the
upgrade/ios-only-rn-0.72.x
branch
5 times, most recently
from
d91e78b
to
c45c96c
Compare
siddarthkay
force-pushed
the
upgrade/ios-only-rn-0.72.x
branch
from
01fcde4
to
9f50d08
Compare
siddarthkay
force-pushed
the
upgrade/ios-only-rn-0.72.x
branch
from
9f50d08
to
50bba78
Compare
|
I briefly had this error after the commit for re-animated upgrade.
|
|
However I am back with my old nemesis and now this is now the latest error. 
|
siddarthkay
force-pushed
the
upgrade/ios-only-rn-0.72.x
branch
5 times, most recently
from
3fc68a6
to
29151ac
Compare
siddarthkay
changed the title
|
IOS Side is ready, time to focus on Android side 
|
siddarthkay
force-pushed
the
upgrade/ios-only-rn-0.72.x
branch
2 times, most recently
from
b6f70bb
to
5871040
Compare
siddarthkay
force-pushed
the
upgrade/ios-only-rn-0.72.x
branch
3 times, most recently
from
1b8940a
to
8b6e3b6
Compare
siddarthkay
force-pushed
the
upgrade/ios-only-rn-0.72.x
branch
from
61bfc81
to
a5cd0a2
Compare
- We need to do this to get rid of react-native-reanimated v1 usage since its incompatible with v3. - Temporarily modifying imports at `src/quo/animated.cljs` and at `src/mocks/js_dependencies.cljs` - A thorough cleanup is required in a follow up.
- We need to do this to because versions of library `react-native-draggable-flatlist` older than `4.0.0` rely on `react-native-reanimated ` v1 and that does not work for us if we wish to upgrade `react-native` further.
`./node_modules/react-native/react.gradle` path no longer exists in `react-native` 0.72.3
- Easing Import - FadeIn swap for Transition Import - easing - linear - Extrapolate - Interpolate
siddarthkay
force-pushed
the
upgrade/ios-only-rn-0.72.x
branch
from
a5cd0a2
to
aef4fdc
Compare
siddarthkay
force-pushed
the
upgrade/ios-only-rn-0.72.x
branch
from
b34d2b4
to
1f4be69
Compare
4 tasks
|
looks stale, feel free to reopen if needed |
siddarthkay
added a commit
that referenced
this pull request
Dec 11, 2023
This PR does many things : - Upgrade `react-native ` to `0.72.5` - Upgrade `react-native-reanimated` to `3.5.4` - Upgrade `react-native-navigation` to `7.37.0` - `ndkVersion` has been bumped to `25.2.9519653` - `cmakeVersion` has been bumped to `3.22.1` - `kotlinVersion` has been bumped to `1.7.22` - `AGP` has been bumped to `7.4.2` - `Gradle` has been upgraded to `8.0.1` - Android `CompileSDK` and `TargetSDK` have been bumped to 33 - `@react-native-async-storage/async-storage` has been upgraded to `1.19.3` - `@walletconnect/client` has been nuked - some of the old `react-native-reanimated` code has been nuked - `react-native-keychain` fork has been replaced with `8.1.2` - On Android we are currently relying on `Hermes` Engine. - On iOS we are currently relying on JSC - We are not enabling new architecture for now (I have plans for that in the future) ref: #18138 IOS only PR : #16721 Android only PR : #17062 - `make run-metro` now has a target of `android` which was `clojure` earlier, this will increase the time it takes to start metro terminal but this is needed otherwise you will get a nasty error while developing for android locally.
siddarthkay
added a commit
that referenced
this pull request
Dec 11, 2023
This commit does many things : - Upgrade `react-native ` to `0.72.5` - Upgrade `react-native-reanimated` to `3.5.4` - Upgrade `react-native-navigation` to `7.37.0` - `ndkVersion` has been bumped to `25.2.9519653` - `cmakeVersion` has been bumped to `3.22.1` - `kotlinVersion` has been bumped to `1.7.22` - `AGP` has been bumped to `7.4.2` - `Gradle` has been upgraded to `8.0.1` - Android `CompileSDK` and `TargetSDK` have been bumped to 33 - `@react-native-async-storage/async-storage` has been upgraded to `1.19.3` - `@walletconnect/client` has been nuked - some of the old `react-native-reanimated` code has been nuked - `react-native-keychain` fork has been replaced with `8.1.2` - On Android we are currently relying on `Hermes` Engine. - On iOS we are currently relying on JSC - We are not enabling new architecture for now (I have plans for that in the future) ref: #18138 IOS only PR : #16721 Android only PR : #17062 - `make run-metro` now has a target of `android` which was `clojure` earlier, this will increase the time it takes to start metro terminal but this is needed otherwise you will get a nasty error while developing for android locally.
siddarthkay
added a commit
that referenced
this pull request
Dec 11, 2023
This commit does many things : - Upgrade `react-native ` to `0.72.5` - Upgrade `react-native-reanimated` to `3.5.4` - Upgrade `react-native-navigation` to `7.37.0` - `ndkVersion` has been bumped to `25.2.9519653` - `cmakeVersion` has been bumped to `3.22.1` - `kotlinVersion` has been bumped to `1.7.22` - `AGP` has been bumped to `7.4.2` - `Gradle` has been upgraded to `8.0.1` - Android `CompileSDK` and `TargetSDK` have been bumped to 33 - `@react-native-async-storage/async-storage` has been upgraded to `1.19.3` - `@walletconnect/client` has been nuked - some of the old `react-native-reanimated` code has been nuked - `react-native-keychain` fork has been replaced with `8.1.2` - On Android we are currently relying on `Hermes` Engine. - On iOS we are currently relying on `JSC` - We are not enabling new architecture for now (I have plans for that in the future) ref: #18138 IOS only PR : #16721 Android only PR : #17062 - `make run-metro` now has a target of `android` which was `clojure` earlier, this will increase the time it takes to start metro terminal but this is needed otherwise you will get a nasty error while developing for android locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just made to test and fix effects of this upgrade on CI.
Note: This PR only contains IOS side of the upgrades.
state: Ready