iOS App after upgrading react-native to 0.72.3 hangs on splash screen with Error: Assert failed: Component must not be nil c

[siddarthkay]

Problem

I have observed this problem while upgrading to react-native 0.70 as well.
Currently reproducible on builds at this PR : #16721
The app will hang at splash screen and when you put the app in background and open it again that is when you will see this error.

Screenshot

Hypothesis

• This is not related to the recent reagent upgrade I have seen the exact same error before the reagent upgrade as well.
• This error originates after upgrading react-native to 0.70 and exists in all further versions. So there must be some thing that changed with that react-native version.
• This error message is related to the generated jsbundle. Somehow the clojurescript code has no build time reagent errors, otherwise it should have failed when running make run-clojure
  Meaning this is a runtime reagent/react error.

reference in reagent repo : reagent-project/reagent#382

[siddarthkay]

I made progress by commenting everything in the init method and console logging my way to see what prints in metro terminal and this way was helpful in listing down a few suspicious files that cause the app to hang on splash screen.

• [status-im2.navigation.view :as views]
• [status-im.transport.message.core :as transport.message]
• [status-im.ui.screens.browser.eip3326.sheet :as sheet]
• [status-im.ui.screens.browser.eip3085.sheet :as sheet]
• [status-im.keycard.core :as keycard]
• [status-im.keycard.card :as keycard.card]
• [status-im.keycard.common :as keycard.common]
• status-im2.subs.root

info Reloading app...
 BUNDLE  ./index.js 

 BUNDLE  ./index.js 

 LOG  we are here at the beginning of init -> src/status_im2/core.cljs
 LOG  we are here at the beginning of start-app -> src/status_im2/events.cljs
 LOG  we here at the end of init, here -> src/status_im2/core.cljs right after dispatching :app-started
 LOG  we here at the beginning of get-profiles-overview-success -> src/status_im2/contexts/profile/events.cljs
 LOG  -> inside else block of get-profiles-overview-success
 LOG  we here at the end of get-profiles-overview-success -> src/status_im2/contexts/profile/events.cljs
 LOG  we are here at the beginning of process -> src/status_im/signals/core.cljs/process
 LOG  shadow-cljs #89 ready!

Investigating further to find the root cause!

[siddarthkay]

After playing minesweeper with the codebase all paths lead to old reanimated implementation.
Cleaning that up fixes this error.
Fixed with : ce77f1f