Bump nim-blscurve #1491
Merged
Bump nim-blscurve #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From supranational/blst#22, passing |
|
Currently synced with Medalla head on this branch (2099:5 67173) (epoch:slot_at_epoch slots_since_genesis) |
|
Jenkins with Milagro fallback test takes twice as long so I'm going to comment it out once this passes. Windows 64-bit goes over the 90min timeout when testing state_sim and block_sim, I will comment them out as well. |
dryajov
pushed a commit
that referenced
this pull request
Aug 17, 2020
* Bump BLSCurve * Use unified aggregation API * use new blscurve with unified aggregate API * bump * fix toRaw * replace state_sim combine with AggregateSignature * Fix 32-bit * Fix 32-bit for real and test deactivating ccache for fno-tree-lopp-vectorize flag * change compilation switches to narrow down Linux issue * Use -fno-tree-vectorize to disable both tree-loop-vectorize and tree-slp-vectorize * blscurve now disables both Loop and SLP vectorization * Add tests for the miracl/milagro fallback * Travis has max log size of 4MB * Test with Miracl in the finalization test * fix state_sim log level * Coment out the slow fallback tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps BLSCurve with the following PRs:
-d:BLS_FORCE_BACKEND=miracl/-d:BLS_FORCE_BACKEND=blst/-d:BLS_FORCE_BACKEND=auto, auto is default and will use BLST on supported platforms (arm64 and x86_64) with Milagro as fallback.Benefits:
Note that unlike the Rust and Go code for aggregate verification, multithreading was not added. See multithreading usage:
Yuriy's threadpool would be a simple, short and maintainable solution if we wanted to go that route https://github.com/yglukhov/threadpools