Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Priv to pub blst #69

Merged
merged 5 commits into from
Aug 12, 2020
Merged

Priv to pub blst #69

merged 5 commits into from
Aug 12, 2020

Conversation

mratsim
Copy link
Contributor

@mratsim mratsim commented Aug 12, 2020

This fixes a bug that appeared when updating nim-blscurve in the NBC repo status-im/nimbus-eth2#1491

NBC is automatically compiled in release mode, which uses -O3 underneath.
BLST is incompatible with some -O3 flags that must be deactivated with -fno-tree-loop-vectorize

The test suite now tests in release mode as well and has been expanded with privToPub vectors

Raised upstream: supranational/blst#22

@mratsim mratsim merged commit 7e5dfb9 into master Aug 12, 2020
@mratsim
Copy link
Contributor Author

mratsim commented Aug 13, 2020

Alternative workaround, passing -Drestrict= which might point to a restrict issue in the BLST code.

@mratsim mratsim deleted the priv-to-pub-blst branch September 7, 2020 12:18
@mratsim mratsim mentioned this pull request Sep 17, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant