Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Rework log levels #1779

Closed
mratsim opened this issue Sep 29, 2020 · 3 comments
Closed

[RFC] Rework log levels #1779

mratsim opened this issue Sep 29, 2020 · 3 comments

Comments

@mratsim
Copy link
Contributor

mratsim commented Sep 29, 2020

As we approach launch, user experience is paramount and we need to review our current logging. In particular several components have significantly matured and might not need the logging we once required during development.

The current debug and trace are very verbose, and filling disks really fast.

In contrary, the "NOTICE" log level is very dry, this is an example of a non-validator node following Spadina for 4 hours after restart in NOTICE

image

It looks like nothing is happening. Some suggestions for user oriented log at the Notice level

  • A "Finality reached" log, this is somewhat different to the log "Finalized with rule XYZ" that we have as that one is also displayed on block replay. The heartbeat happen rarely enough and is significant enough.
  • Warning on low participation level or every X epochs of non-finality
  • Fork in the network
  • High volume of slashing

And also everything related to the users own validators (attestation sent, block proposed, slashings)

@mratsim
Copy link
Contributor Author

mratsim commented Oct 1, 2020

With have a couple of usability problem with trace logs, there are a couple of messages that are per peer but together flood the logs.

Libp2p (1 peer is repeated a lot but you receive one control message per peer per ~1 sec).
image

Fork choice
image

While we have or can write log tooling, we also don't want to fill disks too fast.

@stefantalpalaru
Copy link
Contributor

mratsim added a commit that referenced this issue Oct 1, 2020
* Update log level - #1779 #1785

* Address review comments

* Document the logging strategy [skip ci]
@mratsim
Copy link
Contributor Author

mratsim commented Oct 2, 2020

Closed by #1788. Though we'll likely want to revisit them once again just before launch depending on what we find useful/useless in debug mode to quickly react to eventual launch issues.

@mratsim mratsim closed this as completed Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants