Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update color scheme #89

Merged
merged 3 commits into from
Oct 2, 2020
Merged

update color scheme #89

merged 3 commits into from
Oct 2, 2020

Conversation

mratsim
Copy link
Contributor

@mratsim mratsim commented Oct 1, 2020

This is a bikeshedding proposal on a new color scheme.
The most important part is not making NOTICE look like a warning.

In Debug mode
image

In Trace mode
2020-10-01_19-16

Opinion:

  • The gray might also be used for debug, but I then don't have a good color for trace. White is too eye-catching/bright for a log level as noisy as this.
  • DBG and INF might be not contrasted enough which might make us miss INFO level. But blue is kind of taken by the log content.

References:

chronicles/log_output.nim Outdated Show resolved Hide resolved
@mratsim
Copy link
Contributor Author

mratsim commented Oct 1, 2020

An update to improve:

  • contrast between log-level (Cyan and green are too near)
  • tone down the "aggressiveness":
    • green even dark is too bright for info, cyan is better
    • magenta dark for notice instead of light
  • trace logs are not meant for console but for file and search via tools so they don't take valuable color space anymore

in debug mode this is how it displays.
image

@arnetheduck
Copy link
Member

Screenshot from 2020-10-01 22-27-42

notice a bit hard to pick out on a light background.. readable, just not very different from dbg

@mratsim
Copy link
Contributor Author

mratsim commented Oct 1, 2020

For users I think this is OK since they won't run in debug.

I'm not sure what to do now as the other colors are taken (blue for content) or not contrasted enough, cyan (info) vs green.

image

@mratsim mratsim merged commit b9a7c6b into master Oct 2, 2020
@mratsim mratsim deleted the update-color-scheme branch October 2, 2020 12:01
mratsim added a commit to status-im/nimbus-eth2 that referenced this pull request Oct 2, 2020
arnetheduck pushed a commit to status-im/nimbus-eth2 that referenced this pull request Oct 3, 2020
* Fix discovery log message trigger

* Bump chronicles - include status-im/nim-chronicles#89 for better NOTICE/WARNING color
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants