-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate ENS Dapp! #76
Comments
Adding a bounty to this one. The ask is to format all the ENS DApp strings into a Lokalise compatible file, e.g. |
Another example is status.im using YAML over here https://github.com/status-im/status.im/tree/develop/themes/navy/languages Perhaps @PierrickGT might be interested who just did some translation work at status.im? |
@chadyj yes, I am interested by this task. I've already done some similar work for Balance. You can see what I've worked on in the following PR: |
Sweet @PierrickGT! Good luck! Ping me when you have the EN language file and I'll add to Lokalise then get translators gong :) We also need a way to detect and set the language, and perhaps a way to let the user change the language. WDYT @rachelhamlin ? |
@chadyj will you add a bounty on Gitcoin in the coming days? |
@PierrickGT can you handle device-based language detection as part of this bounty? I'm bumping it up to a medium. @andytudhope will help us get this funded! |
@rachelhamlin yes, I can handle device-based language detection with i18n-js. |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done This issue now has a funding of 300.0 DAI (300.0 USD @ $1.0/DAI) attached to it as part of the Status.im fund.
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work has been started. These users each claimed they can complete the work by 3 years, 2 months ago. 1) lorissikora has applied to start work (Funders only: approve worker | reject worker). I‘m intetested. Could translate to german. I'll first setup i18n-js to detect and load which language should be use depending on the device language. Learn more on the Gitcoin Issue Details page. |
@PierrickGT Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
@chadyj @bgits how can I test the app in local development? I'm connected to the local blockchain running but I've got an error in the console saying that the connection to the endpoint |
@PierrickGT could be an issue with |
@rachelhamlin you mean in my browser or in the app? Cause I don't see any profile section in the app. |
A different version needs to be launched for Ropsten. If your developing
locally you can run the command `embark run testnet`
…On Mon, Nov 26, 2018 at 5:30 PM Pierrick TURELIER ***@***.***> wrote:
@chadyj <https://github.com/chadyj> @bgits <https://github.com/bgits> how
can I test the app in local development?
Cause connected on the Ropsten network through Metamask but after clicking
on the Let's Go button, I get this error message:
Please connect to Ethereum Development to continue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#76 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AD1YSKgxyxSkcJS9Pgikq-qUJvFNiNp3ks5uzGtpgaJpZM4X8jy->
.
|
Still no luck with |
@chadyj @bgits @rachelhamlin I've finished to add the translation on all the pages. |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work for 300.0 DAI (300.0 USD @ $1.0/DAI) has been submitted by: @StatusSceptre please take a look at the submitted work:
|
Thank you @PierrickGT! The changes have been merged and translation files imported into Lokalise. Next, we need contributors to translate the 471 words. We have @jinhojang93 to do Korean. Would love to get Chinese, Farsi, and Russian too. Actually all languages sound good! @pablanopete @j-zerah Can you help get some translators together? (or alternatively we can pay for it via a service for a quick turn around) |
Thanks so much @PierrickGT and @chadyj for managing. What's the best way to filter for the ENS strings on Lokalise? We have someone who can translate to Chinese here in China. |
Sweet! A |
@chadyj got it. Will share with our Chinese community member :) |
Hi all, can I get the context or screens of these strings?
|
Thanks @jinhojang93! Super fast work :)
@bgits @3esmit @rachelhamlin Got screenshots of these? I couldn't find it. btw I uploaded several other screenshots and uploaded to Lokalise for translating context. |
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done The funding of 300.0 DAI (300.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @PierrickGT.
|
The DApp shows extra content if you load it from a normal browser using MetaMask, e.g. Would be great to ultimately remove that content & make it consistent with the mobile version, but @bgits do you recognize these particular strings from @jinhojang93? |
Hi |
We have users all over the world. Let's give them the ENS dapp in their local language. 🇺🇸 🇨🇳 🇫🇷 🇯🇵
The mobile app uses Lokalise to manage the translation of strings and we have a nice UI to manage the translations then a git-based workflow to commit and review changes.
The mobile app uses react-native-i18n, but for this dapp you can use one of these supported file formats https://docs.lokalise.co/supported-file-formats such as json
Once there is a compatible strings file I'd be happy to help setup things on the Lokalise side. Just ping me :)
The text was updated successfully, but these errors were encountered: