This repository has been archived by the owner on Oct 26, 2021. It is now read-only.
Add french translation and format files #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙌 Preview this pull request. Built with commit 9827e32 |
|
Likewise, looks good. I rechecked the translations and I don't think there's anything that needs to be changed at the moment, but I am open to any suggestions as to stylistic choices or errors! |
|
Thanks! Mike is diving in now.
Richard
Sent via Superhuman ( https://sprh.mn/[email protected] )
…On Wed, Jun 20, 2018 at 23:20:28, TigerW1998 < ***@***.*** > wrote:
Likewise, looks good. I rechecked the translations and I don't think
there's anything that needs to be changed at the moment, but I am open to
any suggestions as to stylistic choices or errors!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub (
#315 (comment)
) , or mute the thread (
https://github.com/notifications/unsubscribe-auth/AAavkNr83PeYJH3E94qHS8pJuUp0AKqUks5t-xD8gaJpZM4UvMX4
).
|
mikedemarais
previously requested changes
Jun 22, 2018
src/languages/_french.json
Outdated
| @@ -0,0 +1,196 @@ | |||
| { | |||
| "translation": { | |||
There was a problem hiding this comment.
hey @PierrickGT! could you change the indentation of this file to 2 spaces so that it matches all of our other language files?
thanks!
There was a problem hiding this comment.
other than that it looks great to me! 🎉 will merge once indentation is fixed
|
Hi @mikedemarais, |
jinchung
approved these changes
Jun 26, 2018
|
thanks @PierrickGT ! merged |
|
also thanks @TigerW1998 ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist (check all)
CHANGELOG.mdto describe the included fixes and changes madeIssue number
#304
Changelog