Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched from using 6 small Serializer nugets to one. #279

Merged
merged 2 commits into from
Aug 23, 2022

Conversation

JohannesFinsveen
Copy link
Collaborator

Noticed a bit too late that #163 said ".. All namespaces will be remain as they are to avoid extra work.". They are changed here.

(The buildToAzure breaks in build of PxWeb.Test, as it has TargetFramework netcoreapp3.1)

@JohannesFinsveen JohannesFinsveen requested a review from likp August 22, 2022 12:03
@likp
Copy link
Member

likp commented Aug 23, 2022

I guess we have to do something similar to PxWin soon since we change the namespaces.

Copy link
Member

@likp likp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added a comment about the change in CHANGES.txt otherwise it looks great!

@likp likp merged commit a68fee3 into master Aug 23, 2022
@likp likp deleted the Feature/SwitchNugetsToPCAxis.Serialiers branch August 23, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants