Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure the assemblies/repositories of PxWeb #163

Open
10 of 11 tasks
likp opened this issue Sep 9, 2021 · 7 comments
Open
10 of 11 tasks

Restructure the assemblies/repositories of PxWeb #163

likp opened this issue Sep 9, 2021 · 7 comments
Labels
enhancement New feature or request

Comments

@likp
Copy link
Member

likp commented Sep 9, 2021

Is your feature request related to a problem? Please describe.
There are a lot of different assemblies and repositories that make up PxWeb, that also have dependencies to each other. Making a change in one assembly require us to recompile a hole set of other assemblies that depends on it. This has become more obvious now when we have started to reference them from nuget where we have to build and deploy new nuget packages.

Describe the solution you'd like
Many of the assemblies can be merged into one as long as they are written in the same language. Bellow is a suggested merge strategy. All namespaces will be remain as they are to avoid extra work.

  • Merge PCAxis.Px.Core into PCAxis.Core #225
  • Merge PCAxis.Common into PCAxis.Core #226
  • Merge PCAxis.PxExtened into PCAxis.Charting
  • Merge PCAxis.Html5Table into PCAxis.Serializers (new project/repository)
  • Merge PX.Serializers.Json into PCAxis.Serializers (new project/repository)
  • Merge PCAxis.Sdmx into PCAxis.Serializers (new project/repository)
  • Merge PCAxis.Serializers.JsonStat2 into PCAxis.Serializers (new project/repository)
  • Merge PCAxis.Excel into PCAxis.Serializers (new project/repository)
  • Merge PCAxis.Serializers.JsonStat into PCAxis.Serializers (new project/repository)
  • Merge PCAxis.Encryption into PCAxis.Sql #381
  • Update unit test in PCAxis.Excel so that it is not dependent of PCAxis.PxExtened
@likp likp added the enhancement New feature or request label Sep 9, 2021
@likp
Copy link
Member Author

likp commented Sep 9, 2021

@MikaelNordberg @statisticssweden/ssb any feedback on this?

@JohannesFinsveen
Copy link
Collaborator

I think this sovles the issue of testing the vb serializers with a px-file. (The issue being that I wanted to use PCAxis.PX.core to test the serializers, but PCAxis.PX.core depended on the nuget with the seriazers.

@JohannesFinsveen
Copy link
Collaborator

The 2 PXWeb.SavedQuery.* -nugets are very small and depend on the same "database-nuget" as the sql (as well as the sql).
Could/Should they be included?

@JohannesFinsveen
Copy link
Collaborator

"Merge PCAxis.PxExtened into PCAxis.Charting" Should we make a repo/nuget, or just include the code in the solution?

@likp
Copy link
Member Author

likp commented Sep 9, 2021

"Merge PCAxis.PxExtened into PCAxis.Charting" Should we make a repo/nuget, or just include the code in the solution?

PCAxis.Charting will remain in the PxWeb repository since it is kind of coupled to PxWeb but in the charting project.

@JohannesFinsveen
Copy link
Collaborator

DepsNuggets
I tried to draw it. Hope I didn't miss too much

@JohannesFinsveen
Copy link
Collaborator

The Menu code is still in different nugets/repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants