Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double footer in DOM #324

Merged
merged 8 commits into from
Apr 29, 2024
Merged

Fix double footer in DOM #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3d94c11
remove double divs inside footer
tilen1976 Apr 26, 2024
797c29d
dash run scripts in footer - footer must be unique - version number i…
tilen1976 Apr 26, 2024
58c5293
All page content must be contained by landmarks - set role
tilen1976 Apr 26, 2024
a01ba79
role not unique - removed
tilen1976 Apr 26, 2024
1daeb4d
not valid aria value
tilen1976 Apr 26, 2024
eec683c
move stray element
tilen1976 Apr 26, 2024
294a751
move version to aside element
tilen1976 Apr 26, 2024
36cda6d
remove div version
tilen1976 Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/datadoc/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,7 @@ def build_app(app: type[Dash]) -> Dash:
],
className="main-content-app",
),
html.Footer(
[
build_footer_control_bar(),
],
className="language-footer",
),
build_footer_control_bar(),
],
className="app-wrapper",
)
Expand Down
21 changes: 9 additions & 12 deletions src/datadoc/frontend/components/control_bars.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

from __future__ import annotations

import dash_bootstrap_components as dbc
import ssb_dash_components as ssb
from dash import html

Expand Down Expand Up @@ -32,18 +31,16 @@
)


def build_footer_control_bar() -> dbc.Row:
def build_footer_control_bar() -> html.Aside:
"""Build footer control bar which resides below all the content."""
return dbc.CardBody(
dbc.Row(
[
dbc.Col(
html.P(f"v{get_app_version()}", className="small"),
align="end",
),
],
justify="between",
),
return html.Aside(
children=[
html.P(
f"v{get_app_version()}",
className="small",
),
],
className="language-footer",
)


Expand Down
Loading