Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double footer in DOM #324

Merged
merged 8 commits into from
Apr 29, 2024
Merged

Fix double footer in DOM #324

merged 8 commits into from
Apr 29, 2024

Conversation

tilen1976
Copy link
Contributor

@tilen1976 tilen1976 commented Apr 26, 2024 •
edited
Loading

  • Dash has a Footer outside the inner html and therefor our Footer is not a unique landmark
  • Footer must be unique inside scope
  • Replaced with html Aside

ref: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/aside

@tilen1976 tilen1976 changed the title remove double divs inside footer Fix double footer in DOM Apr 26, 2024
@tilen1976 tilen1976 marked this pull request as ready for review April 26, 2024 19:41
@tilen1976 tilen1976 requested a review from a team as a code owner April 26, 2024 19:41
Jorgen-5
Jorgen-5 approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@Jorgen-5 Jorgen-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@tilen1976 tilen1976 merged commit a0f4b56 into master Apr 29, 2024
16 checks passed
@tilen1976 tilen1976 deleted the fix/footer branch April 29, 2024 06:55
@mmwinther mmwinther added the skip-changelog Changes that should be omitted from the release notes label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jorgen-5 Jorgen-5 Jorgen-5 approved these changes

Assignees
No one assigned
Labels
skip-changelog Changes that should be omitted from the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tilen1976 @Jorgen-5 @mmwinther