refactor(ripple): refactor ubounded ripples as per MDCWeb 0.31.0

material-components/material-components-web#2216
stasson · Feb 24, 2018 · efca3c4 · efca3c4
1 parent 0db8ad6
commit efca3c4
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 44 deletions.
diff --git a/components/card/mdc-card-action-icon.vue b/components/card/mdc-card-action-icon.vue
@@ -35,18 +35,6 @@ export default {
   mounted () {
     this.ripple = new RippleBase(this,{
       isUnbounded: () => true,
-      computeBoundingRect: () => {
-        const dim = 48
-        const {left, top} = this.$el.getBoundingClientRect()
-        return {
-          left,
-          top,
-          width: dim,
-          height: dim,
-          right: left + dim,
-          bottom: left + dim
-        }
-      }
     })
     this.ripple.init()
   },

diff --git a/components/checkbox/mdc-checkbox.vue b/components/checkbox/mdc-checkbox.vue
@@ -101,16 +101,7 @@ export default {
         this.$refs.control.addEventListener(evt, handler)		
       },
       computeBoundingRect: () => {
-        const {left, top} = this.$refs.root.getBoundingClientRect()
-        const DIM = 40
-        return {
-          top,
-          left,
-          right: left + DIM,
-          bottom: top + DIM,
-          width: DIM,
-          height: DIM
-        }
+        return this.$refs.root.getBoundingClientRect()
       }
     })
 

diff --git a/components/icon-toggle/mdc-icon-toggle.vue b/components/icon-toggle/mdc-icon-toggle.vue
@@ -96,18 +96,6 @@ export default {
     this.ripple = new RippleBase(this, {
       isUnbounded: () => true,
       isSurfaceActive: () => this.foundation.isKeyboardActivated(),
-      computeBoundingRect: () => {
-        const dim = 48
-        const {left, top} = this.$el.getBoundingClientRect()
-        return {
-          left,
-          top,
-          width: dim,
-          height: dim,
-          right: left + dim,
-          bottom: left + dim
-        }
-      }
     })
     this.ripple.init()
   },

diff --git a/components/radio/mdc-radio.vue b/components/radio/mdc-radio.vue
@@ -65,16 +65,7 @@ export default {
         this.$refs.control.removeEventListener(evt, handler)
       },
       computeBoundingRect: () => {
-        const {left, top} = this.$refs.root.getBoundingClientRect()
-        const DIM = 40
-        return {
-          top,
-          left,
-          right: left + DIM,
-          bottom: top + DIM,
-          width: DIM,
-          height: DIM
-        }
+        return this.$refs.root.getBoundingClientRect()
       }
     })