fix(ripple): Remove getBoundingClientRect override from unbounded ripples #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2216 +/- ##
==========================================
- Coverage 99.14% 99.13% -0.01%
==========================================
Files 90 90
Lines 3842 3830 -12
Branches 496 496
==========================================
- Hits 3809 3797 -12
Misses 33 33
Continue to review full report at Codecov.
|
kfranqueiro
approved these changes
Feb 8, 2018
There was a problem hiding this comment.
Huh. I don't notice any difference before/after these changes so LGTM. This might've been another kludge necessary earlier when unbounded ripples had issues.
Nit though: I'd reword the commit subject to fix: Remove getBoundingClientRect override from unbounded ripples
(fix(ripple) makes it sound like this affects the ripple package itself, but it doesn't)
moog16
changed the title
stasson
added a commit
to stasson/vue-mdc-adapter
that referenced
this pull request
Feb 24, 2018
stasson
added a commit
to stasson/vue-mdc-adapter
that referenced
this pull request
Feb 24, 2018
Havret
added a commit
to Havret/material-components-react
that referenced
this pull request
Feb 25, 2018
Havret
added a commit
to Havret/material-components-react
that referenced
this pull request
Feb 25, 2018
* Fix unbounded ripple sizes material-components/material-components-web#2092 * Remove computeBoundingRect override for Checkbox ripple material-components/material-components-web#2216 * Update docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.