Region-based Looping (a.k.a. A/B looping) utilizing videojs-abloop plugin #3904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 8, 2023 01:15
- buttons controlling looping added. neat.
chickenwingavalanche
changed the title
|
I was really hoping this would make 0.22. What's the chances of that build fail getting fixed by .23? |
|
I've made the display of the UI elements optional and turned off by default, since - as you mentioned - they are pretty hideous. You can enable them in the Interface settings. |
|
Apologies for the drive by, and thank you for carrying it over the line @WithoutPants ! |
halkeye
pushed a commit
to halkeye/stash
that referenced
this pull request
Sep 1, 2024
…ugin (stashapp#3904) * yarn add videojs-abloop * add abLoop plugin to video player * adding player keyboard shortcut 'l' for toggling a/b looping copies mpv behavior: if a/b loop start not yet set, sets start to current player time elif a/b loop stop not yet set, sets end to current player time and enables loop else, disables a/b loop relates to stashapp#3264 (stashapp#3264) * update help with keyboard shortcut * Add plugin type definitions * Make UI elements optional --------- Co-authored-by: chickenwingavalanche <[email protected]> Co-authored-by: WithoutPants <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds A/B looping support to the player, as requested in #3264.
I don't really love the UI elements that the plugin provides, and am open to doing something different if the maintainers have a suggestion.
lsets the start timela second time, sets the end time and starts the loopingla third time, stops the a/b loopScreenshots of current state:
A/B looping is off, no times have been selected:
lhas been hit twice, enabling the a/b loop:Resolves #3264