-
-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Region-based Looping (a.k.a. A/B looping) #3264
Comments
I think could be added to marker. Set end point on marker also allow looping |
That would be a way to do it, but I'm picturing something that doesn't have to leave behind an artifact like a Marker--it's just an ephemeral behavior of the player. mpv and its derivatives all do this. In mpv, when a video is playing you can hit "L" to toggle looping the whole video (which would also be nice), or "l" (that's a lower case L) to flag the start point, then "l" again to flag the endpoint and jump the player back to the start point. When it hits the end point, it jumps back to the start point again. When the user hits "l" a third time, the points are cleared and play proceeds normally from wherever the playhead is. |
I'd really like to see end time and looping for markers. If you could use the simple mpv type approach to looping and then create a marker from that, it would be great as well. |
Hey look, there's a plugin for it: https://github.com/phhu/videojs-abloop |
A/B looper as an ephemeral feature of the video player can be a distinct, but related, feature from the "end" timestamp of the Marker. Selecting a marker with an end time would just pre-configure the video player. Having a/b loop be part of the Marker system gives it all the same niceties such as tagging, animated previews, global search, backups, etc. With that said, the marker thumbnail would need a distinct way to distinguish itself from a typical bookmark-like marker. |
I've started work toward this feature on my fork and would like to get this merged in for everyone 😄 As an initial step, I've integrated the plugin suggested above, and added |
…ugin (#3904) * yarn add videojs-abloop * add abLoop plugin to video player * adding player keyboard shortcut 'l' for toggling a/b looping copies mpv behavior: if a/b loop start not yet set, sets start to current player time elif a/b loop stop not yet set, sets end to current player time and enables loop else, disables a/b loop relates to #3264 (#3264) * update help with keyboard shortcut * Add plugin type definitions * Make UI elements optional --------- Co-authored-by: chickenwingavalanche <[email protected]> Co-authored-by: WithoutPants <[email protected]>
…ugin (stashapp#3904) * yarn add videojs-abloop * add abLoop plugin to video player * adding player keyboard shortcut 'l' for toggling a/b looping copies mpv behavior: if a/b loop start not yet set, sets start to current player time elif a/b loop stop not yet set, sets end to current player time and enables loop else, disables a/b loop relates to stashapp#3264 (stashapp#3264) * update help with keyboard shortcut * Add plugin type definitions * Make UI elements optional --------- Co-authored-by: chickenwingavalanche <[email protected]> Co-authored-by: WithoutPants <[email protected]>
While playing a video, enable the user to mark the start and end points of a region of the video. The player will then loop that region until stopped by the user.
The text was updated successfully, but these errors were encountered: