Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wait-interpolation-smooth for objects not to run away from gripper #1742

Merged
merged 2 commits into from
Jun 23, 2016

Conversation

pazeshun
Copy link
Collaborator

I'll check if this is effective for rawlings_baseball, easter_turtle_sippy_cup, kleenex_tissue_box, soft_white_lightbulb, folgers_classic_roast_coffee and up_glucose_bottle. They easily slide too far when gripper push them.

@ban-masa
Copy link
Collaborator

+1

@pazeshun pazeshun force-pushed the use-wait-interpolation-smooth branch from aecc611 to 0542c7f Compare June 20, 2016 04:08
@pazeshun
Copy link
Collaborator Author

This PR needs jsk-ros-pkg/jsk_pr2eus#236

@pazeshun pazeshun force-pushed the use-wait-interpolation-smooth branch from 0542c7f to bc42f33 Compare June 22, 2016 08:02
@pazeshun pazeshun changed the title [WIP] Use wait-interpolation-smooth for objects not to run away from gripper Use wait-interpolation-smooth for objects not to run away from gripper Jun 22, 2016
@pazeshun
Copy link
Collaborator Author

Tested in real robot with jsk-ros-pkg/jsk_pr2eus#236

@k-okada
Copy link
Member

k-okada commented Jun 22, 2016

the PR is merged and released.

◉ Kei Okada

On Wed, Jun 22, 2016 at 5:18 PM, pazeshun [email protected] wrote:

Tested in real robot with jsk-ros-pkg/jsk_pr2eus#236
jsk-ros-pkg/jsk_pr2eus#236


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1742 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAeG3CtVSfzQXxNXZqOxgIxX5jm3chfwks5qOO_GgaJpZM4I49Di
.

@pazeshun pazeshun force-pushed the use-wait-interpolation-smooth branch from bc42f33 to 2c67298 Compare June 22, 2016 13:59
@pazeshun
Copy link
Collaborator Author

pazeshun commented Jun 22, 2016

@k-okada Thank you!
rebase origin/master and add 2c67298 to use jsk-ros-pkg/jsk_pr2eus#236
After this PR is merged, please wstool update

@pazeshun
Copy link
Collaborator Author

pazeshun commented Jun 22, 2016

@wkentaro Is 2c67298 correct approach? If you think so, please merge this.

@@ -39,6 +39,10 @@
uri: https://github.com/jsk-ros-pkg/jsk_robot.git
version: master
- git:
local-name: jsk-ros-pkg/jsk_pr2eus
uri: https://github.com/jsk-ros-pkg/jsk_pr2eus.git
version: master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version: 0.3.4

@pazeshun pazeshun force-pushed the use-wait-interpolation-smooth branch from 2c67298 to 464921c Compare June 22, 2016 15:06
@pazeshun
Copy link
Collaborator Author

Fixed

@ban-masa
Copy link
Collaborator

+1

@pazeshun pazeshun changed the title Use wait-interpolation-smooth for objects not to run away from gripper [WIP] Use wait-interpolation-smooth for objects not to run away from gripper Jun 23, 2016
@pazeshun pazeshun changed the title [WIP] Use wait-interpolation-smooth for objects not to run away from gripper Use wait-interpolation-smooth for objects not to run away from gripper Jun 23, 2016
@wkentaro wkentaro merged commit b1ee27d into start-jsk:master Jun 23, 2016
@pazeshun pazeshun deleted the use-wait-interpolation-smooth branch June 23, 2016 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants