Adjust ProjectConfig to remove implicit assumption that discriminator == version

[piotmag769]

Currently there is no way to specify the discriminator for a crate itself, so we do a wild guess and assume that it is equal to version. I also removed the ProjectConfig.corelib field that seems obsolete: API user can pass this information via ProjectConfigContent.content_roots.

[reviewable-StarkWare]

This change is 

[orizi]

Reviewed 2 of 9 files at r2, all commit messages.
Reviewable status: 2 of 10 files reviewed, 1 unresolved discussion (waiting on @Arcticae, @Draggu, @maciektr, @mkaput, and @piotmag769)

---

crates/cairo-lang-filesystem/src/db.rs line 31 at r2 (raw file):

/// This directly translates to [`DependencySettings.discriminator`] expect the discriminator
/// **must** be `None` for the core crate.
pub type CrateIdentifier = SmolStr;

either do a type wrapper - or remove the alias.
`pub struct CrateIdentifier(SmolStr);

Code quote:

pub type CrateIdentifier = SmolStr;

[mkaput]

Reviewable status: 2 of 10 files reviewed, 2 unresolved discussions (waiting on @Arcticae, @Draggu, @maciektr, and @piotmag769)

a discussion (no related file):
I don't understand these changes. Why do you need these?

As far as I know things, the discriminator == version equality is used because this is a model that cairo_project.toml uses. There's open path to skip this requirement by directly interning things in *Database, which we do everywhere we want to, don't we?

---

[mkaput]

Reviewable status: 2 of 10 files reviewed, 3 unresolved discussions (waiting on @Arcticae, @Draggu, @maciektr, and @piotmag769)

a discussion (no related file):
You're mixing two changes in a single PR here, please make a stack

---

[mkaput]

Reviewable status: 2 of 10 files reviewed, 2 unresolved discussions (waiting on @Arcticae, @Draggu, @maciektr, and @piotmag769)

a discussion (no related file):

Previously, mkaput (Marek Kaput) wrote…

I don't understand these changes. Why do you need these?

As far as I know things, the discriminator == version equality is used because this is a model that cairo_project.toml uses. There's open path to skip this requirement by directly interning things in *Database, which we do everywhere we want to, don't we?

discussed offline. we need these changes anyway for scarb eject to be possible

---

[Draggu]

Reviewed 1 of 7 files at r1, 9 of 9 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Arcticae, @maciektr, and @piotmag769)

[piotmag769]

Reviewed 1 of 7 files at r1, 9 of 9 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Arcticae, @maciektr, and @orizi)

---

crates/cairo-lang-filesystem/src/db.rs line 31 at r2 (raw file):

Previously, orizi wrote…

either do a type wrapper - or remove the alias.
`pub struct CrateIdentifier(SmolStr);

Done.

[piotmag769]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Arcticae, @maciektr, and @orizi)

[piotmag769]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Arcticae, @maciektr, @mkaput, and @orizi)

[orizi]

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Arcticae, @maciektr, @mkaput, and @piotmag769)

[piotmag769]

Closing in favour of PR stack: #6511 #6512