Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for crate keyword. #6284

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Added support for crate keyword. #6284

merged 1 commit into from
Aug 26, 2024

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Aug 26, 2024

Closes #3178


This change is Reviewable

Closes #3178

commit-id:0d402d27
@orizi orizi changed the base branch from spr/main/60d16b1e to main August 26, 2024 13:17
Copy link
Contributor

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 74 of 75 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)

Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 75 of 75 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi added this pull request to the merge queue Aug 26, 2024
Merged via the queue into main with commit b47c0fa Aug 26, 2024
87 checks passed
@enitrat
Copy link
Contributor

enitrat commented Aug 26, 2024

💯 awesome!

@orizi orizi deleted the spr/main/0d402d27 branch August 28, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: crate keyword
4 participants