Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: crate keyword #3178

Closed
1 of 2 tasks
taco-paco opened this issue May 17, 2023 · 4 comments · Fixed by #6284
Closed
1 of 2 tasks

feat: crate keyword #3178

taco-paco opened this issue May 17, 2023 · 4 comments · Fixed by #6284
Labels
enhancement New feature or request

Comments

@taco-paco
Copy link
Contributor

Feature Request

Describe the Feature Request

Have crate keyword as in Rust.

Describe Preferred Solution

using crate instead of possibly long crate names + its more explicit that imports are from current package.

Describe Alternatives

Related Code

crates/cairo-lang-semantic/src/resolve/mod.rs

Additional Context

If the feature request is approved, would you be willing to submit a PR?
(Help can be provided if you need assistance submitting a PR)

  • Yes
  • No
@taco-paco taco-paco added the enhancement New feature or request label May 17, 2023
@Jinwei1987
Copy link

does help is needed for this issue?

@taco-paco
Copy link
Contributor Author

does help is needed for this issue?

There’s an open pr. Waiting for feedback from starkware

@enitrat
Copy link
Contributor

enitrat commented Aug 26, 2024

@orizi bumping this 🙏

@orizi
Copy link
Collaborator

orizi commented Aug 26, 2024

checking if this can happen without particular breaking changes.

orizi added a commit that referenced this issue Aug 26, 2024
Closes #3178

commit-id:0d402d27
orizi added a commit that referenced this issue Aug 26, 2024
Closes #3178

commit-id:0d402d27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants