-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add storage node mutable variant. #5929
Conversation
491e9af
to
3496069
Compare
1090760
to
0017a64
Compare
3496069
to
b720556
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)
crates/cairo-lang-starknet/src/plugin/storage_node.rs
line 270 at r1 (raw file):
} /// Generates the trait and impl for a storage node.
fix doc.
0017a64
to
502331b
Compare
b720556
to
c33a4db
Compare
c33a4db
to
7d3374e
Compare
321286b
to
d800501
Compare
7d3374e
to
199b8d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)
crates/cairo-lang-starknet/src/plugin/storage_node.rs
line 270 at r2 (raw file):
} /// Generates the storage node structs (two variants, mutable and immutable) and their contrtor
?
Code quote:
contrtor
199b8d6
to
c489eae
Compare
d800501
to
6c7c936
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)
crates/cairo-lang-starknet/src/plugin/storage_node.rs
line 270 at r2 (raw file):
Previously, orizi wrote…
?
Done.
c489eae
to
5437b8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)
6c7c936
to
61101c6
Compare
5437b8b
to
95cc839
Compare
61101c6
to
c602b4c
Compare
815f4c8
to
647b92d
Compare
647b92d
to
5c5a055
Compare
c602b4c
to
d264ed9
Compare
commit-id:1683e7f0
5c5a055
to
5169cc4
Compare
This change is