Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage node mutable variant. #5929

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

gilbens-starkware
Copy link
Contributor

@gilbens-starkware gilbens-starkware commented Jul 1, 2024

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)


crates/cairo-lang-starknet/src/plugin/storage_node.rs line 270 at r1 (raw file):

}

/// Generates the trait and impl for a storage node.

fix doc.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)


crates/cairo-lang-starknet/src/plugin/storage_node.rs line 270 at r2 (raw file):

}

/// Generates the storage node structs (two variants, mutable and immutable) and their contrtor

?

Code quote:

contrtor

Copy link
Contributor Author

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)


crates/cairo-lang-starknet/src/plugin/storage_node.rs line 270 at r2 (raw file):

Previously, orizi wrote…

?

Done.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)

@gilbens-starkware gilbens-starkware changed the base branch from spr/main/357a8f6c to main July 2, 2024 12:24
@gilbens-starkware gilbens-starkware added this pull request to the merge queue Jul 2, 2024
Merged via the queue into main with commit 715a66a Jul 2, 2024
86 of 87 checks passed
@orizi orizi deleted the spr/main/1683e7f0 branch July 3, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants