-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move contracts imports to prelude. #5925
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 27 of 27 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)
902e5c8
to
3feacfb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)
a discussion (no related file):
how will this play with an idea to move starknet
out of core
crate?
3feacfb
to
eb4b9fe
Compare
530975b
to
8803d4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 5 of 27 files reviewed, 1 unresolved discussion (waiting on @mkaput and @orizi)
a discussion (no related file):
Previously, mkaput (Marek Kaput) wrote…
how will this play with an idea to move
starknet
out ofcore
crate?
It's only for past editions (not 2024_07).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 5 of 27 files reviewed, all discussions resolved (waiting on @orizi)
a discussion (no related file):
Previously, gilbens-starkware (Gil Ben-Shachar) wrote…
It's only for past editions (not 2024_07).
oh I see, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 22 of 22 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)
eb4b9fe
to
934b4f5
Compare
ac78143
to
e7be983
Compare
934b4f5
to
8c43692
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)
8c43692
to
1090760
Compare
e7be983
to
33f7230
Compare
1090760
to
0017a64
Compare
33f7230
to
7152873
Compare
0017a64
to
502331b
Compare
502331b
to
321286b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 27 files at r1, 22 of 22 files at r2, 2 of 2 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)
ef9607c
to
0921aad
Compare
321286b
to
d800501
Compare
6c7c936
to
61101c6
Compare
862d6c1
to
a6bb954
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)
61101c6
to
c602b4c
Compare
commit-id:357a8f6c
c602b4c
to
d264ed9
Compare
Stack:
This change is