Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add PartialOrdSnap impl #5723

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

tdelabro
Copy link
Contributor

@tdelabro tdelabro commented Jun 4, 2024

closes #5646 until we address #5694


This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tdelabro)


corelib/src/traits.cairo line 122 at r1 (raw file):

    }
    
}

Suggestion:

        PartialOrd::<T>::gt(*lhs, *rhs)
    }
}

Copy link
Contributor Author

@tdelabro tdelabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)


corelib/src/traits.cairo line 122 at r1 (raw file):

    }
    
}

Done.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tdelabro)

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)

a discussion (no related file):
@gilbens-starkware for 2nd eye.


Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tdelabro)

@gilbens-starkware gilbens-starkware added this pull request to the merge queue Jun 5, 2024
Merged via the queue into starkware-libs:main with commit 91d4813 Jun 5, 2024
43 checks passed
@tdelabro tdelabro deleted the impl-PartialOrdSnap branch June 5, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add a PartialOrdSnap impl in the corelib
3 participants