Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a PartialOrdSnap impl in the corelib #5646

Closed
tdelabro opened this issue May 27, 2024 · 0 comments · Fixed by #5723
Closed

feat: add a PartialOrdSnap impl in the corelib #5646

tdelabro opened this issue May 27, 2024 · 0 comments · Fixed by #5723
Labels
enhancement New feature or request

Comments

@tdelabro
Copy link
Contributor

Feature Request

My problem is that +PartialOrd<T> currently doesn't imply +PartialOrd<@T>. Which is inconsistent because it is implied for PartialEq.
The reason being this specific impl:

impl PartialEqSnap<T, +PartialEq<T>> of PartialEq<@T> {
fn eq(lhs: @@T, rhs: @@T) -> bool {
PartialEq::<T>::eq(*lhs, *rhs)
}
}

I think this should be extended to PartialOrd for sure and most likely to other traits in the corelib, like Add and so on.

If the feature request is approved, would you be willing to submit a PR?
(Help can be provided if you need assistance submitting a PR)

No. It is quite simple and will do for a great set of OnlyDust contributions, once the lib owner decides which trait are concerned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant