This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(dropdown): change header and content types from string to shorthand #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silviuaavram
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1054 +/- ##
==========================================
+ Coverage 82.35% 82.37% +0.01%
==========================================
Files 733 733
Lines 8712 8720 +8
Branches 1233 1168 -65
==========================================
+ Hits 7175 7183 +8
Misses 1522 1522
Partials 15 15
Continue to review full report at Codecov.
|
silviuaavram
force-pushed
the
fix-change-prop-types-dropdown
branch
from
af4471b
to
ff9c099
Compare
mnajdova
reviewed
Mar 26, 2019
silviuaavram
force-pushed
the
fix-change-prop-types-dropdown
branch
from
ff9c099
to
bf3188f
Compare
bmdalex
reviewed
Mar 27, 2019
mnajdova
reviewed
Mar 29, 2019
mnajdova
reviewed
Mar 29, 2019
bmdalex
previously requested changes
Mar 29, 2019
mnajdova
reviewed
Apr 1, 2019
docs/src/examples/components/Dropdown/Types/DropdownExampleMultiple.shorthand.steps.ts
Show resolved
Hide resolved
mnajdova
approved these changes
Apr 2, 2019
This was referenced Mar 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested by People team.
Also to be in sync with the changes of the prop types in list.
made
contentandheaderprops fromDropdownItemandheaderfromDropdownSelectedItemto be shorthand.