Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding 7 new icons #12212

Merged
merged 10 commits into from
Mar 13, 2020
Merged

Adding 7 new icons #12212

merged 10 commits into from
Mar 13, 2020

Conversation

TanelVari
Copy link
Contributor

@TanelVari TanelVari commented Mar 6, 2020 •
edited
Loading

Adding 'raise hand', 'raise hand colored', 'raise hand disabled', 'merge calls', 'share location', 'panorama' and 'spotlight' icons

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change
Microsoft Reviewers: Open in CodeFlow

@msft-github-bot msft-github-bot added the Fluent UI react-northstar (v0) Work related to Fluent UI V0 label Mar 6, 2020
@size-auditor
Copy link

size-auditor bot commented Mar 6, 2020 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: f7f26d455753eacf83e249baf84563c93c91ee55 (build)

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Mar 6, 2020 •
edited
Loading

Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Status
BaseButton 624 575
BaseButton (experiments) 877 805
DefaultButton 889 886
DefaultButton (experiments) 1478 1578
DetailsRow 3041 2785
DetailsRow (fast icons) 3121 2893
DetailsRow without styles 2903 2996
DocumentCardTitle with truncation 1570 1560
MenuButton 1222 1228
MenuButton (experiments) 3088 3118
PrimaryButton 1046 1056
PrimaryButton (experiments) 1771 1795
SplitButton 2636 2585
SplitButton (experiments) 6377 6420
Stack 406 409
Stack with Intrinsic children 1013 995
Stack with Text children 3677 3600
Text 324 330
Toggle 724 751
Toggle (experiments) 1991 1985
button 55 51

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.44 0.38 1.16:1 2000 871
🎯 Button.Fluent 0.12 0.17 0.71:1 1000 121
🔧 Checkbox.Fluent 0.6 0.3 2:1 1000 603
🔧 Dialog.Fluent 0.32 0.19 1.68:1 5000 1603
🔧 Dropdown.Fluent 2.95 0.39 7.56:1 1000 2952
🔧 Icon.Fluent 0.14 0.04 3.5:1 5000 675
🎯 Image.Fluent 0.06 0.08 0.75:1 5000 275
🔧 Slider.Fluent 1.33 0.35 3.8:1 1000 1330
🔧 Text.Fluent 0.06 0.02 3:1 5000 310
🦄 Tooltip.Fluent 0.1 13.64 0.01:1 5000 507

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 135 118 1.14:1
ListMinimalPerf.default 377 338 1.12:1
FlexMinimalPerf.default 239 218 1.1:1
Button.Fluent 121 110 1.1:1
Text.Fluent 310 283 1.1:1
ListWith60ListItems.default 180 165 1.09:1
TreeWith60ListItems.default 190 174 1.09:1
IconMinimalPerf.default 332 307 1.08:1
AccordionMinimalPerf.default 215 201 1.07:1
TreeMinimalPerf.default 1012 958 1.06:1
AnimationMinimalPerf.default 524 501 1.05:1
ListCommonPerf.default 851 814 1.05:1
DropdownManyItemsPerf.default 295 283 1.04:1
HierarchicalTreeMinimalPerf.default 813 780 1.04:1
TooltipMinimalPerf.default 768 738 1.04:1
Tooltip.Fluent 507 489 1.04:1
CheckboxMinimalPerf.default 2772 2683 1.03:1
LabelMinimalPerf.default 290 281 1.03:1
ListNestedPerf.default 781 761 1.03:1
ChatDuplicateMessagesPerf.default 347 339 1.02:1
HeaderSlotsPerf.default 1358 1335 1.02:1
PopupMinimalPerf.default 210 206 1.02:1
ProviderMergeThemesPerf.default 1130 1104 1.02:1
TextAreaMinimalPerf.default 2741 2677 1.02:1
Slider.Fluent 1330 1299 1.02:1
AttachmentMinimalPerf.default 769 763 1.01:1
SegmentMinimalPerf.default 944 933 1.01:1
Avatar.Fluent 871 860 1.01:1
Checkbox.Fluent 603 597 1.01:1
Image.Fluent 275 272 1.01:1
MenuButtonMinimalPerf.default 1296 1301 1:1
SliderMinimalPerf.default 1308 1302 1:1
TableMinimalPerf.default 543 542 1:1
AlertMinimalPerf.default 517 523 0.99:1
AttachmentSlotsPerf.default 3143 3166 0.99:1
ButtonSlotsPerf.default 514 521 0.99:1
DividerMinimalPerf.default 851 862 0.99:1
EmbedMinimalPerf.default 4729 4757 0.99:1
LoaderMinimalPerf.default 908 918 0.99:1
CustomToolbarPrototype.default 3120 3153 0.99:1
ToolbarMinimalPerf.default 903 910 0.99:1
VideoMinimalPerf.default 720 728 0.99:1
Dialog.Fluent 1603 1616 0.99:1
CarouselMinimalPerf.default 1730 1765 0.98:1
DialogMinimalPerf.default 1590 1620 0.98:1
DropdownMinimalPerf.default 3027 3092 0.98:1
InputMinimalPerf.default 899 915 0.98:1
LayoutMinimalPerf.default 552 562 0.98:1
PortalMinimalPerf.default 234 240 0.98:1
Dropdown.Fluent 2952 3007 0.98:1
AvatarMinimalPerf.default 475 491 0.97:1
HeaderMinimalPerf.default 437 451 0.97:1
ProviderMinimalPerf.default 542 556 0.97:1
SplitButtonMinimalPerf.default 10458 10805 0.97:1
FormMinimalPerf.default 733 764 0.96:1
RadioGroupMinimalPerf.default 416 433 0.96:1
ReactionMinimalPerf.default 2008 2097 0.96:1
Icon.Fluent 675 701 0.96:1
ChatWithPopoverPerf.default 498 522 0.95:1
ImageMinimalPerf.default 269 282 0.95:1
ItemLayoutMinimalPerf.default 1716 1799 0.95:1
MenuMinimalPerf.default 1661 1765 0.94:1
StatusMinimalPerf.default 265 281 0.94:1
TextMinimalPerf.default 288 306 0.94:1
BoxMinimalPerf.default 280 302 0.93:1
GridMinimalPerf.default 709 760 0.93:1
ChatMinimalPerf.default 442 478 0.92:1
RefMinimalPerf.default 166 192 0.86:1

layershifter
layershifter approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changelog before merging 👍

@TanelVari TanelVari changed the title Adding 4 new icons Adding 6 new icons Mar 11, 2020
@TanelVari TanelVari closed this Mar 11, 2020
@TanelVari TanelVari reopened this Mar 11, 2020
@TanelVari TanelVari changed the title Adding 6 new icons Adding 7 new icons Mar 12, 2020
@microsoft microsoft deleted a comment from DustyTheBot Mar 12, 2020
@TanelVari TanelVari closed this Mar 12, 2020
@TanelVari TanelVari reopened this Mar 12, 2020
@microsoft microsoft deleted a comment from DustyTheBot Mar 12, 2020
@TanelVari TanelVari closed this Mar 12, 2020
@TanelVari TanelVari reopened this Mar 12, 2020
@TanelVari TanelVari merged commit 536d49c into microsoft:master Mar 13, 2020
@TanelVari TanelVari deleted the TanelVari/iconsForFluent-05-03-20 branch March 13, 2020 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layershifter layershifter layershifter approved these changes

@dzearing dzearing Awaiting requested review from dzearing

@ecraig12345 ecraig12345 Awaiting requested review from ecraig12345

@JasonGore JasonGore Awaiting requested review from JasonGore

@jdhuntington jdhuntington Awaiting requested review from jdhuntington

@levithomason levithomason Awaiting requested review from levithomason

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny

@mnajdova mnajdova Awaiting requested review from mnajdova

@pompomon pompomon Awaiting requested review from pompomon

@silviuaavram silviuaavram Awaiting requested review from silviuaavram

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar

Assignees

@aneeshack4 aneeshack4

Labels
Fluent UI react-northstar (v0) Work related to Fluent UI V0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TanelVari @msft-github-bot @layershifter @aneeshack4