Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated 'raise hand' icons after bug bash comments #12342

Merged
merged 3 commits into from
Mar 19, 2020
Merged

Updated 'raise hand' icons after bug bash comments #12342

merged 3 commits into from
Mar 19, 2020

Conversation

TanelVari
Copy link
Contributor

@TanelVari TanelVari commented Mar 17, 2020

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

(give an overview)

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Mar 18, 2020

Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Status
BaseButton 734 740
BaseButton (experiments) 899 895
DefaultButton 1022 1025
DefaultButton (experiments) 1767 1848
DetailsRow 3129 3208
DetailsRow (fast icons) 3299 3200
DetailsRow without styles 2953 3020
DocumentCardTitle with truncation 1569 1608
MenuButton 1273 1307
MenuButton (experiments) 3299 3230
PrimaryButton 1120 1098
PrimaryButton (experiments) 1835 1880
SplitButton 3198 2964
SplitButton (experiments) 6644 6691
Stack 439 437
Stack with Intrinsic children 1064 1071
Stack with Text children 3723 3778
Text 340 347
Toggle 821 831
Toggle (experiments) 2156 2116
button 64 58

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.54 0.48 1.13:1 2000 1083
🦄 Button.Fluent 0.09 0.18 0.5:1 5000 442
🔧 Checkbox.Fluent 0.75 0.36 2.08:1 1000 747
🔧 Dialog.Fluent 0.4 0.2 2:1 5000 1980
🔧 Dropdown.Fluent 3.77 0.48 7.85:1 1000 3765
🔧 Icon.Fluent 0.17 0.05 3.4:1 5000 840
🎯 Image.Fluent 0.07 0.09 0.78:1 5000 348
🔧 Slider.Fluent 1.65 0.39 4.23:1 1000 1647
🔧 Text.Fluent 0.08 0.02 4:1 5000 378
🦄 Tooltip.Fluent 0.12 19.26 0.01:1 5000 624

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TableMinimalPerf.default 703 642 1.1:1
ProviderMinimalPerf.default 728 665 1.09:1
DividerMinimalPerf.default 1065 983 1.08:1
ListNestedPerf.default 970 903 1.07:1
ListWith60ListItems.default 1272 1193 1.07:1
AvatarMinimalPerf.default 588 556 1.06:1
IconMinimalPerf.default 418 396 1.06:1
PopupMinimalPerf.default 251 237 1.06:1
ChatWithPopoverPerf.default 636 606 1.05:1
AttachmentSlotsPerf.default 3839 3690 1.04:1
ButtonMinimalPerf.default 146 141 1.04:1
HeaderSlotsPerf.default 1724 1661 1.04:1
ListMinimalPerf.default 440 423 1.04:1
TooltipMinimalPerf.default 884 848 1.04:1
Slider.Fluent 1647 1586 1.04:1
Text.Fluent 378 365 1.04:1
AttachmentMinimalPerf.default 975 949 1.03:1
ImageMinimalPerf.default 339 329 1.03:1
TreeWith60ListItems.default 236 230 1.03:1
Tooltip.Fluent 624 608 1.03:1
AlertMinimalPerf.default 618 606 1.02:1
BoxMinimalPerf.default 351 345 1.02:1
HeaderMinimalPerf.default 572 561 1.02:1
ItemLayoutMinimalPerf.default 2146 2097 1.02:1
LoaderMinimalPerf.default 1120 1098 1.02:1
RadioGroupMinimalPerf.default 528 520 1.02:1
ReactionMinimalPerf.default 2580 2531 1.02:1
InputMinimalPerf.default 1099 1088 1.01:1
MenuButtonMinimalPerf.default 1585 1566 1.01:1
ProviderMergeThemesPerf.default 1384 1376 1.01:1
SplitButtonMinimalPerf.default 12894 12747 1.01:1
TextAreaMinimalPerf.default 3247 3210 1.01:1
VideoMinimalPerf.default 916 907 1.01:1
Icon.Fluent 840 835 1.01:1
AnimationMinimalPerf.default 642 639 1:1
ButtonSlotsPerf.default 619 621 1:1
ListCommonPerf.default 1033 1037 1:1
SegmentMinimalPerf.default 1113 1109 1:1
TextMinimalPerf.default 378 378 1:1
CustomToolbarPrototype.default 3921 3918 1:1
CarouselMinimalPerf.default 2096 2113 0.99:1
ChatDuplicateMessagesPerf.default 427 430 0.99:1
EmbedMinimalPerf.default 5671 5737 0.99:1
PortalMinimalPerf.default 284 286 0.99:1
SliderMinimalPerf.default 1615 1628 0.99:1
Avatar.Fluent 1083 1095 0.99:1
Dialog.Fluent 1980 1992 0.99:1
Dropdown.Fluent 3765 3797 0.99:1
CheckboxMinimalPerf.default 3319 3376 0.98:1
DropdownMinimalPerf.default 3643 3713 0.98:1
LayoutMinimalPerf.default 649 660 0.98:1
MenuMinimalPerf.default 1998 2036 0.98:1
StatusMinimalPerf.default 602 612 0.98:1
Checkbox.Fluent 747 764 0.98:1
ChatMinimalPerf.default 574 593 0.97:1
DialogMinimalPerf.default 1940 1999 0.97:1
DropdownManyItemsPerf.default 1502 1544 0.97:1
Button.Fluent 442 455 0.97:1
Image.Fluent 348 357 0.97:1
ToolbarMinimalPerf.default 1131 1174 0.96:1
TreeMinimalPerf.default 1200 1254 0.96:1
RefMinimalPerf.default 197 208 0.95:1
FormMinimalPerf.default 900 961 0.94:1
GridMinimalPerf.default 850 900 0.94:1
AccordionMinimalPerf.default 239 262 0.91:1
FlexMinimalPerf.default 257 281 0.91:1
HierarchicalTreeMinimalPerf.default 1054 1164 0.91:1
LabelMinimalPerf.default 354 390 0.91:1

@size-auditor
Copy link

size-auditor bot commented Mar 18, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 36ed94b0250ee3316e9aaec4697ced1cf229dcb1 (build)

@microsoft microsoft deleted a comment from DustyTheBot Mar 18, 2020
@TanelVari TanelVari closed this Mar 18, 2020
@TanelVari TanelVari reopened this Mar 18, 2020
@DustyTheBot
Copy link

DustyTheBot commented Mar 18, 2020

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS against 8c28cf2

@TanelVari TanelVari closed this Mar 19, 2020
@TanelVari TanelVari reopened this Mar 19, 2020
@TanelVari TanelVari merged commit 34f1d9d into microsoft:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fluent UI react-northstar (v0) Work related to Fluent UI V0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants