Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Defining default path spec in ingress if hosts.*.paths is null" #247

Merged
merged 11 commits into from
Jul 7, 2023
Merged

Revert "Defining default path spec in ingress if hosts.*.paths is null" #247

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8e8d00a
Revert "Make servicePort overrides possible with ingress hosts"
mustafaStakater Apr 3, 2023
452b3d5
Update changelog
mustafaStakater Apr 3, 2023
3f8c385
update changelog
mustafaStakater Apr 3, 2023
87b95b7
[application/templates/ingress] remove default paths block, fail on m…
mustafaStakater Apr 13, 2023
196b3d4
[application] update values.yaml and values-test.yaml
mustafaStakater Apr 13, 2023
4abd386
Merge branch 'master' into revert-previous-change-remove-service-port…
mustafaStakater Apr 13, 2023
58f68dc
Merge branch 'master' into revert-previous-change-remove-service-port…
aslafy-z Jul 5, 2023
6f6b0c9
Update CHANGELOG.md
aslafy-z Jul 5, 2023
ada6b85
Merge branch 'master' into revert-previous-change-remove-service-port…
aslafy-z Jul 6, 2023
bee7958
fix chlog #minor
mustafaStakater Jul 7, 2023
2a6b322
specify vpa version
mustafaStakater Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@

All notable changes to this project will be documented here.

### v2.1.19
- Fix: Reverts [PR-240](https://github.com/stakater/application/pull/240), This can already be configured via `paths` [PR-247](https://github.com/stakater/application/pull/247)

### v2.1.18
- feat: Add vertical pod autoscaler template [PR-249](https://github.com/stakater/application/pull/249)

Expand All @@ -24,7 +27,7 @@ All notable changes to this project will be documented here.
- Fix: make deployment.image.tag and job.image.tag optional [PR-234](https://github.com/stakater/application/pull/234)

### v2.1.12
- Caused by Change Log update
- Update: Changelog updates. This release shouldnt have been made as the head commit had [`[skip ci]`](https://docs.github.com/en/actions/managing-workflow-runs/skipping-workflow-runs). [PR-248](https://github.com/stakater/application/pull/248)

### v2.1.11
- Feature: Add topologySpreadConstraints [PR-239](https://github.com/stakater/application/pull/239)
Expand Down
8 changes: 1 addition & 7 deletions application/templates/ingress.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,7 @@ spec:
name: {{ default "http" (.servicePort) }}
{{- end }}
{{- else }}
- path: "/"
pathType: "ImplementationSpecific"
backend:
service:
name: {{ $applicationNameTpl }}
port:
name: {{ default "http" (.servicePort) }}
{{ fail "Specify paths for ingress host, check values.yaml" }}
{{- end }}
{{- end -}}
{{- if .Values.ingress.tls }}
Expand Down
3 changes: 1 addition & 2 deletions application/values-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,8 +280,7 @@ ingress:
# List of host addresses to be exposed by this Ingress

hosts:
- host: chart-example-1.local
- host: chart-example-2.local
- host: chart-example.local
paths:
- path: /
# pathType: ''
Expand Down
4 changes: 2 additions & 2 deletions application/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,8 +358,8 @@ ingress:
# List of host addresses to be exposed by this Ingress
hosts:
- host: chart-example.local
# paths:
# - path: /
paths:
- path: /
# pathType: ''
# serviceName: ''
# servicePort: ''
Expand Down