Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Defining default path spec in ingress if hosts.*.paths is null" #247

Merged

Conversation

mustafaStakater
Copy link
Contributor

@mustafaStakater mustafaStakater commented Apr 3, 2023

This reverts PR #240.

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

@mustafaStakater validation successful`

d3adb5
d3adb5 previously approved these changes Apr 8, 2023
Copy link
Collaborator

@d3adb5 d3adb5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally don't see the problem with allowing use of a simpler interface for this kind of thing, though I wonder how often it would be used and whether its use should even be recommended over reproducing the classic Ingress path structure.

Nevertheless, I'm approving this one for now, but would also like to hear @rasheedamir's and @aslafy-z's opinions.

@d3adb5 d3adb5 requested review from rasheedamir and aslafy-z April 8, 2023 16:03
@mustafaStakater
Copy link
Contributor Author

mustafaStakater commented Apr 13, 2023

hmmmm, It creates redundancy in a sense that we can already define the same configuration via paths value.

I will be removing the else block so that users are forced to define basic paths value to avoid ambiguity. @d3adb5

@aslafy-z
Copy link
Collaborator

aslafy-z commented Apr 13, 2023

@mustafaStakater @d3adb5 I'd prefer to keep it simple and only expose the standard ingress path format as values. I think we can drop servicePort and serviceName too. However, if we go that way, it becomes a breaking change, thus, we'll have to bump the major.

@mustafaStakater
Copy link
Contributor Author

mustafaStakater commented Apr 14, 2023

We might have usecase for specifying multiple paths. @aslafy-z

@aslafy-z
Copy link
Collaborator

aslafy-z commented Jul 5, 2023

By "expose the standard ingress path format as values" I meant expose the whole paths list in the values as done in this revert. Ok to me.

aslafy-z
aslafy-z previously approved these changes Jul 5, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
@aslafy-z aslafy-z changed the title Revert "Make servicePort overrides possible with ingress hosts" Revert "Defining default path spec in ingress if hosts.*.paths is null" Jul 5, 2023
aslafy-z
aslafy-z previously approved these changes Jul 5, 2023
d3adb5
d3adb5 previously approved these changes Jul 6, 2023
Copy link
Collaborator

@d3adb5 d3adb5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this could break someone's existing setup, if they're reliant on the path fallback. It's not exactly warranting of a major bump, but caution is always good.

@rasheedamir
Copy link
Member

@mustafaStakater what do you think? should we do major bump?

@mustafaStakater
Copy link
Contributor Author

mustafaStakater commented Jul 7, 2023

minor bump looks ok to me, a major bump seems too much

@mustafaStakater
Copy link
Contributor Author

we can merge this

@hussnain612 hussnain612 merged commit d637d8e into master Jul 7, 2023
@hussnain612 hussnain612 deleted the revert-previous-change-remove-service-port-override branch July 7, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants