-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Defining default path spec in ingress if hosts.*.paths is null" #247
Revert "Defining default path spec in ingress if hosts.*.paths is null" #247
Conversation
This reverts commit 1d19633.
@mustafaStakater validation successful` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally don't see the problem with allowing use of a simpler interface for this kind of thing, though I wonder how often it would be used and whether its use should even be recommended over reproducing the classic Ingress path structure.
Nevertheless, I'm approving this one for now, but would also like to hear @rasheedamir's and @aslafy-z's opinions.
…issing paths along with host
@mustafaStakater @d3adb5 I'd prefer to keep it simple and only expose the standard ingress path format as values. I think we can drop |
We might have usecase for specifying multiple paths. @aslafy-z |
By "expose the standard ingress path format as values" I meant expose the whole |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this could break someone's existing setup, if they're reliant on the path fallback. It's not exactly warranting of a major bump, but caution is always good.
@mustafaStakater what do you think? should we do major bump? |
minor bump looks ok to me, a major bump seems too much |
we can merge this |
This reverts PR #240.