Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: GridViews and NavigationViews #144

Merged
merged 8 commits into from
Jul 15, 2024
Merged

Android: GridViews and NavigationViews #144

merged 8 commits into from
Jul 15, 2024

Conversation

Archdoog
Copy link
Collaborator

@Archdoog Archdoog commented Jul 13, 2024 •
edited
Loading

  • Adds the InnerGridView & NavigationInnerGridView
  • Adds zoom control & centering control
  • Optimizes camera control to apply on map ready to allow user to unset by panning.
  • Adds Portait and Landscape NavigationViews
  • Adds DynamicallyOrientingNavigationView
  • Optimizes Demo App architecture to more realistically reflect common dependency injection patterns (without actually installing a heavy library like koin).

TODO BEFORE MERGE

Closes #135
Closes #136

@Archdoog Archdoog self-assigned this Jul 14, 2024
@Archdoog Archdoog marked this pull request as ready for review July 14, 2024 19:28
@Archdoog Archdoog requested a review from ianthetechie July 14, 2024 19:28
@Archdoog
Copy link
Collaborator Author

Merge #149 First!!!

@ianthetechie
Copy link
Contributor

Huh... I merged #149 first but it says there are conflicts 😂

ianthetechie
ianthetechie approved these changes Jul 15, 2024
View reviewed changes
...ui/src/main/java/com/stadiamaps/ferrostar/composeui/views/controls/NavigationUIZoomButton.kt
containerColor = containerColor,
contentColor = contentColor,
elevation = elevation) {
Icon(imageVector = Icons.Filled.Add, contentDescription = "Zoom In")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll only comment on one occurrence, but we make all of these string resources for localization at some point. Tracked in #151.

android/demo-app/src/main/java/com/stadiamaps/ferrostar/AppModule.kt Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh! I really like this design! Keeps all the details out in a separate file.

@ianthetechie ianthetechie merged commit 27a5641 into main Jul 15, 2024
12 checks passed
@ianthetechie ianthetechie deleted the feat/android/grid-views branch July 15, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianthetechie ianthetechie ianthetechie approved these changes

Assignees

@Archdoog Archdoog

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Archdoog @ianthetechie