Android: ArrivalView, supporting formatters and updated testing #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archdoog
commented
Jul 10, 2024
...src/test/snapshots/images/com.stadiamaps.ferrostar.views_ArrivalViewTest_testArrivalView.png
Outdated
Show resolved
Hide resolved
1 task
Archdoog
changed the title
ianthetechie
approved these changes
Jul 14, 2024
| @@ -157,9 +166,12 @@ jobs: | |||
|
|
|||
| - name: 'Upload Artifact' | |||
| uses: actions/upload-artifact@v4 | |||
| if: success() || failure() | |||
There was a problem hiding this comment.
Ooh, interesting... I think the intent here is more closely matched by "not cancelled?" If so, I'm not quite sure why the job would be running anyways ; shouldn't cancellation stop all other jobs in the workflow? Or does GH Actions work differently? ;)
| - name: 'Upload Artifact' | ||
| uses: actions/upload-artifact@v4 | ||
| if: success() || failure() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #65 (installation will be deferred to bringing the dynamic nav map view into android)