Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs for Github Personal Access Token #122

Merged

Conversation

haysmike
Copy link
Collaborator

Looks like the build is looking for gpr.token instead of gpr.key now.

@Archdoog
Copy link
Collaborator

Something broke swift format vs the uniffi generated ferrostar.swift file and I had to re-generate it by:

  1. Running build-ios.sh from within the common/ folder.
  2. Running swiftformat . from the root folder.

This is fixed in #119, but we could probably get this PR here merged first since it's an easier approve if we wanted to fix that here first.

@ianthetechie
Copy link
Contributor

Yeah, honestly I wish there was a good way to set up CI workflows so that it's just commit on your branch if you forgot to swiftformat :P There's no good solution... even pre-commit hooks won't work here since you may have an old version of swiftformat.

@ianthetechie
Copy link
Contributor

I just quick fixed it to merge both this and #123.

@ianthetechie ianthetechie merged commit a00df59 into stadiamaps:main Jun 22, 2024
8 of 9 checks passed
@haysmike haysmike deleted the haysmike/fix-access-token-docs branch July 16, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants