Feat/ios speed limit view

[Archdoog]

No description provided.

[ianthetechie]

I'm not quite sold on a "theme" also including locale settings. Those seem like separate concepts.

[ianthetechie]

I am not sure this is the best way to go about deciding which speed limit to show. For one, the US isn't the only country to use mph for speed limits.

Second, I'm pretty convinced that locale is not the correct way to set speed display preference.

I think we can punt on the specifics of this for the moment and:

1. Have it be a pair of preferences for the moment (maybe bundled into the theme / display units / formatter stuff??). It's really a pair of preferences: do you want the US/MUTCD style or Vienna Convention style that's used almost everywhere else. If I were designing this, I'd make it vary on geography, but that's way out of scope for now ;)
2. Move the logic at the use site (get rid of this view wrapper until we have a better idea of how users want to determine it automatically).

[Archdoog]

Consider how this could become a SpeedLimitProvider (e.g. to take locale, manual inputs, or a route admins list).

Add comment that this needs to improve in the future. & Make it easy to override.

[ianthetechie]

I also noticed that several of the tests are (now?) nondeterministic.

1. Dark mode probably needs to be explicitly set for snapshot tests.
2. Arrival view tests almost all fail on my machine; snapshots expect feet; my laptop uses meters.
3. Default formatter tests make the same error since they don't explicitly set certain locale details in testDistanceFormatter and testEstimatedArrivalFormatter.

[Archdoog]

1. Add environment settings like dark mode/light mode to tests. Tests need explicit formatters (time zones, etc), environment dark mode & environment locale (units).
2. Add a readme discussion that the simulator needs to exactly match.

[Archdoog]

Consider how this could become a SpeedLimitProvider (e.g. to take locale, manual inputs, or a route admins list).

Add comment that this needs to improve in the future. & Make it easy to override.

[ianthetechie]

Ooh interesting... Is this to fix the text color (which I guess might default to white in dark mode)? If so, maybe we can just set the text color explicitly?

[Archdoog]

This fixes the speed limit sign colors to light mode. Since it's something we don't want to invert (basically maintaining the white background and black text regardless of the device's color mode).

[ianthetechie]

Leaving a comment for posterity because this was EXTREMELY interesting... Apparently named colors (ex: .green) may be aware of light/dark mode, and resolve to different hex values! That's both unexpected but also kinda cool.