-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep dockerfiles up to date #919
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
# To get started with Dependabot version updates, you'll need to specify which | ||
# package ecosystems to update and where the package manifests are located. | ||
# Please see the documentation for all configuration options: | ||
# https://help.github.com/github/administering-a-repository/configuration-options-for-dependency-updates | ||
|
||
version: 2 | ||
updates: | ||
- package-ecosystem: 'docker' | ||
directory: collector/connscrape-test/ | ||
schedule: | ||
interval: "weekly" | ||
- package-ecosystem: 'docker' | ||
directory: collector/container/ | ||
schedule: | ||
interval: "weekly" | ||
- package-ecosystem: 'docker' | ||
directory: integration-tests/container/benchmark/ | ||
schedule: | ||
interval: "weekly" | ||
- package-ecosystem: 'docker' | ||
directory: integration-tests/container/containerstats/ | ||
schedule: | ||
interval: "weekly" | ||
- package-ecosystem: 'docker' | ||
directory: integration-tests/container/jsonlabel/ | ||
schedule: | ||
interval: "weekly" | ||
- package-ecosystem: 'docker' | ||
directory: integration-tests/container/perf/ | ||
schedule: | ||
interval: "weekly" | ||
- package-ecosystem: 'docker' | ||
directory: integration-tests/container/processes-listening-on-ports/ | ||
schedule: | ||
interval: "weekly" | ||
- package-ecosystem: 'docker' | ||
directory: integration-tests/container/schedule-curls/ | ||
schedule: | ||
interval: "weekly" | ||
- package-ecosystem: 'docker' | ||
directory: oss-public-server/container/ | ||
schedule: | ||
interval: "weekly" | ||
- package-ecosystem: 'docker' | ||
directory: utilities/shellcheck-all/ | ||
schedule: | ||
interval: "weekly" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have 2 dockerfiles here:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should dependabot/feedback#145
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That link talks about dependabot finding files with names other than
Dockerfile
, I'm more concerned about the actual content of the dockerfile:collector/collector/container/Dockerfile.template
Lines 1 to 5 in 3433fd8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I give it a test and you are right, args are not updated https://github.com/janisz/collector/pulls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If Dockefile.ubi is not being used right now, why not deleting it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delayed response. Basically, that image was used as a mirror to the downstream release, it fell out of use because OSCI is similar enough to downstream and we didn't bother to re-implement it. But now we are considering going to GHA, so it might make sense to go back to building this image.