Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep dockerfiles up to date #919

Merged
merged 3 commits into from
Dec 7, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions .github/dependabot.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
# To get started with Dependabot version updates, you'll need to specify which
# package ecosystems to update and where the package manifests are located.
# Please see the documentation for all configuration options:
# https://help.github.com/github/administering-a-repository/configuration-options-for-dependency-updates

version: 2
updates:
- package-ecosystem: 'docker'
directory: collector/connscrape-test/
schedule:
interval: "weekly"
- package-ecosystem: 'docker'
directory: collector/container/
Comment on lines +12 to +13
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have 2 dockerfiles here:

Dockerfile.template uses ARGs to set the image being used as base and I'm not sure dependabot will pick up on it.
Dockefile.ubi is not being used right now, so updating it would not really have any effect.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That link talks about dependabot finding files with names other than Dockerfile, I'm more concerned about the actual content of the dockerfile:

ARG BASE_REGISTRY=registry.access.redhat.com
ARG BASE_IMAGE=ubi8/ubi-minimal
ARG BASE_TAG=8.6
FROM ${BASE_REGISTRY}/${BASE_IMAGE}:${BASE_TAG}

Copy link
Contributor Author

@janisz janisz Nov 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I give it a test and you are right, args are not updated https://github.com/janisz/collector/pulls

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Dockefile.ubi is not being used right now, why not deleting it?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delayed response. Basically, that image was used as a mirror to the downstream release, it fell out of use because OSCI is similar enough to downstream and we didn't bother to re-implement it. But now we are considering going to GHA, so it might make sense to go back to building this image.

schedule:
interval: "weekly"
- package-ecosystem: 'docker'
directory: integration-tests/container/benchmark/
schedule:
interval: "weekly"
- package-ecosystem: 'docker'
directory: integration-tests/container/containerstats/
schedule:
interval: "weekly"
- package-ecosystem: 'docker'
directory: integration-tests/container/jsonlabel/
schedule:
interval: "weekly"
- package-ecosystem: 'docker'
directory: integration-tests/container/perf/
schedule:
interval: "weekly"
- package-ecosystem: 'docker'
directory: integration-tests/container/processes-listening-on-ports/
schedule:
interval: "weekly"
- package-ecosystem: 'docker'
directory: integration-tests/container/schedule-curls/
schedule:
interval: "weekly"
- package-ecosystem: 'docker'
directory: oss-public-server/container/
schedule:
interval: "weekly"
- package-ecosystem: 'docker'
directory: utilities/shellcheck-all/
schedule:
interval: "weekly"