Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Custom Dockerfile name / multiple Dockerfiles per repo #145

Closed
danmaas opened this issue Aug 17, 2018 · 12 comments
Closed

Custom Dockerfile name / multiple Dockerfiles per repo #145

danmaas opened this issue Aug 17, 2018 · 12 comments

Comments

@danmaas
Copy link

danmaas commented Aug 17, 2018

Hi - I have a repo with a couple of Dockerfiles named something other than "Dockerfile", e.g.

./Dockerfile-manager
./Dockerfile-webserver
./Dockerfile-backup-agent

I would like there to be an option in Dependabot's Docker configuration to specify a custom Dockerfile name.

Also, it would be nice to handle multiple Dockerfiles within a single repo, either by registering them as separate "languages", or by managing them as a group.

@nesl247
Copy link

nesl247 commented Aug 19, 2018

I too have multiple in almost all of my repos. We have one for nginx , php-fpm, etc.

@greysteil
Copy link
Contributor

greysteil commented Aug 21, 2018

An easy start here would be for Dependabot to fetch and update all files with the word dockerfile in them. I'll implement that now and have it deployed in the next couple of hours.

After that adding support for arbitrary names shouldn't be too tricky. I'll try to get to that today, too.

@greysteil
Copy link
Contributor

OK, Dependabot will now update all files with the word dockerfile in them (commits are here).

Are either of you using names that it would miss, given the above? I'll close this if not.

@nesl247
Copy link

nesl247 commented Aug 21, 2018

I just use Dockerfile in different directories.

@greysteil
Copy link
Contributor

Ah cool - Dependabot should already be able to handle that if you just add multiple update configs, one for each language. I think that's probably the best long-term solution there - I could set Dependabot up to trawl your repo for any files called Dockerfile, but can see that being the wrong behaviour for some people.

@nesl247
Copy link

nesl247 commented Aug 21, 2018

I actually didn't know we could add the same language multiple times. That works for me.

@greysteil
Copy link
Contributor

Yeah, I could definitely clean up the UI on that...

@danmaas - does the current change work for you, too?

@danmaas
Copy link
Author

danmaas commented Aug 21, 2018

Yes, a case-insensitive match against dockerfile in the filename should work fine.

@greysteil
Copy link
Contributor

Awesome - going to close for now, and will revisit if other need even more custom names. Thanks for the feedback!

@connorshea
Copy link

@greysteil this'd be nice to have documented somewhere :) I almost opened an issue about how to go about setting multiple Dockerfiles in the config.yml (I have two Dockerfiles, called Dockerfile and Dockerfile.ci).

@greysteil
Copy link
Contributor

Agreed. I'll have think on where we can put it.

@hawksight
Copy link

hawksight commented Jan 29, 2020

Not sure this is documented here, has anyone got an example config, or is it just a case of naming the dockerfiles with the string dockerfile in them?
Is it also case sensitive?, so app.Dockerfile would not work?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants