ROX-18679: containerize integration tests #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
Stringy
force-pushed
the
giles/ROX-15295-containerize-integration-tests
branch
from
6a48d14 to
9129aef
Compare
Stringy
force-pushed
the
giles/ROX-15295-containerize-integration-tests
branch
3 times, most recently
from
7d1f1a8 to
a5bea14
Compare
Stringy
commented
Oct 12, 2023
Stringy
commented
Oct 12, 2023
Stringy
force-pushed
the
giles/ROX-15295-containerize-integration-tests
branch
from
553ca12 to
3b2e835
Compare
Molter73
reviewed
Oct 19, 2023
| if: ${{ !contains(github.event.pull_request.labels.*.name, 'skip-integration-tests') }} | ||
| # Temporarily disable benchmarks due to baseline calculation | ||
| # inconsistencies. This will be fixed and re-enabled in the future. | ||
| if: false # ${{ !contains(github.event.pull_request.labels.*.name, 'skip-integration-tests') }} |
There was a problem hiding this comment.
This could probably be done in a separate PR, it'd be merged much faster I'd assume.
|
Running integration tests locally worked for me TestRepeatedNetworkFlow failed, but it always fails for me. |
Stringy
force-pushed
the
giles/ROX-15295-containerize-integration-tests
branch
from
85565fe to
ae6e3b1
Compare
erthalion
approved these changes
Oct 20, 2023
Since we're using buildx to build multi-arch images, all of this is handled by Go implicitly, at least in the sense that it's building a 'native' binary for each platform (via qemu) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Containerize the integration tests, to bundle common dependencies and files. Now that we're running on the test host, containerizing the tests will make it easier to create test bundles and traceable artifacts for each build/test run.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
Images built locally, but relying on CI for additional testing of multi-arch builds and end-to-end use of the resulting images.