Skip to content

Commit

Permalink
Fix perf.json file location to make it easier to retrieve from test h…
Browse files Browse the repository at this point in the history
…osts
  • Loading branch information
Stringy committed Oct 10, 2023
1 parent 129fc70 commit 7d1f1a8
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:

- name: Calculate Baseline
run: |
jq -s 'flatten' perf.json > integration-tests/perf-all.json
jq -s 'flatten' container-logs/**/perf.json > integration-tests/perf-all.json
./integration-tests/scripts/baseline/main.py --test integration-tests/perf-all.json \
| sort \
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/integration-tests-vm-type.yml
Original file line number Diff line number Diff line change
Expand Up @@ -188,5 +188,4 @@ jobs:
name: ${{ inputs.vm_type }}-logs
path: |
${{ github.workspace }}/integration-tests/container-logs/**/*
${{ github.workspace }}/integration-tests/perf.json
${{ github.workspace }}/integration-tests/performance-logs/**/*
Original file line number Diff line number Diff line change
Expand Up @@ -119,13 +119,6 @@
loop_control:
loop_var: remote_log_path

- name: Download perf JSON
fetch:
src: "{{ remote_log_mount }}/perf.json"
dest: "{{ integration_tests_root }}/"
flat: true
fail_on_missing: false

- name: Write integration test log
copy:
content: "{{ test_result.stdout }}"
Expand Down
3 changes: 2 additions & 1 deletion integration-tests/suites/base.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"encoding/json"
"fmt"
"os"
"path/filepath"
"regexp"
"strconv"
"strings"
Expand Down Expand Up @@ -192,7 +193,7 @@ func (s *IntegrationTestSuiteBase) WritePerfResults() {
}

perfJson, _ := json.Marshal(perf)
perfFilename := "perf.json"
perfFilename := filepath.Join(config.LogPath(), "perf.json")

fmt.Printf("Writing %s\n", perfFilename)
f, err := os.OpenFile(perfFilename, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0644)
Expand Down

0 comments on commit 7d1f1a8

Please sign in to comment.