Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-13456: Bump detect-secrets to 1.4.0 #679

Merged
merged 3 commits into from
Dec 21, 2022
Merged

ROX-13456: Bump detect-secrets to 1.4.0 #679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4a35f1
ROX-13456: Upgrade detect-secrets
kovayur Dec 15, 2022
3dfbb52
Update .secrets.baseline after rebase
kovayur Dec 20, 2022
8bda2e7
Fix .secrets.baseline after rebase
kovayur Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,10 @@ repos:
stages: [push, manual]
files: '(openapi/.*|pkg/workers/worker_interface.go|pkg/client/ocm/id.go|pkg/client/aws/client.go|pkg/client/ocm/client.go|pkg/client/iam/client.go|pkg/services/authorization/authorization.go|pkg/services/sso/iam_service.go|pkg/client/redhatsso/client.go|pkg/auth/auth_agent_service.go|internal/dinosaur/pkg/services/observatorium_service.go|internal/dinosaur/pkg/services/cluster_placement_strategy.go|internal/dinosaur/pkg/services/cloud_providers.go|internal/dinosaur/pkg/services/clusters.go|internal/dinosaur/pkg/services/quota.go|internal/dinosaur/pkg/services/fleetshard_operator_addon.go|internal/dinosaur/pkg/services/quota_service_factory.go|internal/dinosaur/pkg/clusters/cluster_builder.go|internal/dinosaur/pkg/clusters/provider.go|internal/dinosaur/pkg/services/dinosaur.go)'
- repo: https://github.com/Yelp/detect-secrets
rev: v1.2.0
rev: v1.4.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be awesome to use dependabot for this, but sadly pre-commit is not supported by it yet :(

hooks:
- id: detect-secrets
args: ["--baseline", ".secrets.baseline"]
exclude: ^pkg/client/redhatsso/api/
- repo: https://github.com/golangci/golangci-lint
rev: v1.50.1
hooks:
Expand Down
222 changes: 219 additions & 3 deletions .secrets.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "1.2.0",
"version": "1.4.0",
"plugins_used": [
{
"name": "ArtifactoryDetector"
Expand Down Expand Up @@ -110,6 +110,13 @@
],
"results": {
"config/jwks-file-static.json": [
{
"type": "Base64 High Entropy String",
"filename": "config/jwks-file-static.json",
"hashed_secret": "ed62b47fd3b50efa5ac26528e55d81092af405f9",
"is_verified": false,
"line_number": 4
},
{
"type": "Base64 High Entropy String",
"filename": "config/jwks-file-static.json",
Expand All @@ -118,6 +125,13 @@
"line_number": 8,
"is_secret": false
},
{
"type": "Base64 High Entropy String",
"filename": "config/jwks-file-static.json",
"hashed_secret": "cfed69888acbd1a5a2dc12a093d1e1141af05807",
"is_verified": false,
"line_number": 12
},
{
"type": "Base64 High Entropy String",
"filename": "config/jwks-file-static.json",
Expand All @@ -126,6 +140,13 @@
"line_number": 16,
"is_secret": false
},
{
"type": "Base64 High Entropy String",
"filename": "config/jwks-file-static.json",
"hashed_secret": "5ec9a1a2e3f33fdd442f873acc689c75ecb1b60a",
"is_verified": false,
"line_number": 20
},
{
"type": "Base64 High Entropy String",
"filename": "config/jwks-file-static.json",
Expand All @@ -134,6 +155,13 @@
"line_number": 24,
"is_secret": false
},
{
"type": "Base64 High Entropy String",
"filename": "config/jwks-file-static.json",
"hashed_secret": "01cfde694c3ae081d9d48c49948f83f862f11039",
"is_verified": false,
"line_number": 28
},
{
"type": "Base64 High Entropy String",
"filename": "config/jwks-file-static.json",
Expand All @@ -152,6 +180,13 @@
}
],
"config/jwks-file.json": [
{
"type": "Base64 High Entropy String",
"filename": "config/jwks-file.json",
"hashed_secret": "ed62b47fd3b50efa5ac26528e55d81092af405f9",
"is_verified": false,
"line_number": 4
},
{
"type": "Base64 High Entropy String",
"filename": "config/jwks-file.json",
Expand All @@ -160,6 +195,13 @@
"line_number": 8,
"is_secret": false
},
{
"type": "Base64 High Entropy String",
"filename": "config/jwks-file.json",
"hashed_secret": "cfed69888acbd1a5a2dc12a093d1e1141af05807",
"is_verified": false,
"line_number": 12
},
{
"type": "Base64 High Entropy String",
"filename": "config/jwks-file.json",
Expand All @@ -168,6 +210,13 @@
"line_number": 16,
"is_secret": false
},
{
"type": "Base64 High Entropy String",
"filename": "config/jwks-file.json",
"hashed_secret": "5ec9a1a2e3f33fdd442f873acc689c75ecb1b60a",
"is_verified": false,
"line_number": 20
},
{
"type": "Base64 High Entropy String",
"filename": "config/jwks-file.json",
Expand All @@ -176,6 +225,13 @@
"line_number": 24,
"is_secret": false
},
{
"type": "Base64 High Entropy String",
"filename": "config/jwks-file.json",
"hashed_secret": "01cfde694c3ae081d9d48c49948f83f862f11039",
"is_verified": false,
"line_number": 28
},
{
"type": "Base64 High Entropy String",
"filename": "config/jwks-file.json",
Expand All @@ -195,6 +251,71 @@
"is_secret": false
}
],
"dev/env/manifests/shared/03-configmap-config.yaml": [
{
"type": "Base64 High Entropy String",
"filename": "dev/env/manifests/shared/03-configmap-config.yaml",
"hashed_secret": "13032f402fed753c2248419ea4f69f99931f6dbc",
"is_verified": false,
"line_number": 52
},
{
"type": "Base64 High Entropy String",
"filename": "dev/env/manifests/shared/03-configmap-config.yaml",
"hashed_secret": "30025f80f6e22cdafb85db387d50f90ea884576a",
"is_verified": false,
"line_number": 52
},
{
"type": "Base64 High Entropy String",
"filename": "dev/env/manifests/shared/03-configmap-config.yaml",
"hashed_secret": "355f24fd038bcaf85617abdcaa64af51ed19bbcf",
"is_verified": false,
"line_number": 52
},
{
"type": "Base64 High Entropy String",
"filename": "dev/env/manifests/shared/03-configmap-config.yaml",
"hashed_secret": "3d8a1dcd2c3c765ce35c9a9552d23273cc4ddace",
"is_verified": false,
"line_number": 52
},
{
"type": "Base64 High Entropy String",
"filename": "dev/env/manifests/shared/03-configmap-config.yaml",
"hashed_secret": "4ac7b0522761eba972467942cd5cd7499dd2c361",
"is_verified": false,
"line_number": 52
},
{
"type": "Base64 High Entropy String",
"filename": "dev/env/manifests/shared/03-configmap-config.yaml",
"hashed_secret": "7639ab2a6bcf2ea30a055a99468c9cd844d4c22a",
"is_verified": false,
"line_number": 52
},
{
"type": "Base64 High Entropy String",
"filename": "dev/env/manifests/shared/03-configmap-config.yaml",
"hashed_secret": "b56360daf4793d2a74991a972b34d95bc00fb2da",
"is_verified": false,
"line_number": 52
},
{
"type": "Base64 High Entropy String",
"filename": "dev/env/manifests/shared/03-configmap-config.yaml",
"hashed_secret": "c9a73ef9ee8ce9f38437227801c70bcc6740d1a1",
"is_verified": false,
"line_number": 52
},
{
"type": "Base64 High Entropy String",
"filename": "dev/env/manifests/shared/03-configmap-config.yaml",
"hashed_secret": "14736999d9940728c5294277831a702f7882dece",
"is_verified": false,
"line_number": 89
}
],
"fleetshard/pkg/central/cloudprovider/dbclient_moq.go": [
{
"type": "Secret Keyword",
Expand All @@ -204,6 +325,15 @@
"line_number": 105
}
],
"internal/dinosaur/pkg/api/public/api/openapi.yaml": [
{
"type": "Base64 High Entropy String",
"filename": "internal/dinosaur/pkg/api/public/api/openapi.yaml",
"hashed_secret": "5b455797b93de5b6a19633ba22127c8a610f5c1b",
"is_verified": false,
"line_number": 1663
}
],
"pkg/client/iam/client_moq.go": [
{
"type": "Secret Keyword",
Expand Down Expand Up @@ -286,7 +416,7 @@
"filename": "pkg/client/redhatsso/api/api/openapi.yaml",
"hashed_secret": "e5e9fa1ba31ecd1ae84f75caaa474f3a663f05f4",
"is_verified": false,
"line_number": 183
"line_number": 184
}
],
"pkg/shared/secrets/secrets_test.go": [
Expand All @@ -299,17 +429,103 @@
"is_secret": false
}
],
"templates/envoy-config-configmap.yml": [
{
"type": "Secret Keyword",
"filename": "templates/envoy-config-configmap.yml",
"hashed_secret": "9d51dabe59aa776bef2909d3689374ebb93ab2be",
"is_verified": false,
"line_number": 10
}
],
"templates/service-template.yml": [
{
"type": "Base64 High Entropy String",
"filename": "templates/service-template.yml",
"hashed_secret": "13032f402fed753c2248419ea4f69f99931f6dbc",
"is_verified": false,
"line_number": 542
},
{
"type": "Base64 High Entropy String",
"filename": "templates/service-template.yml",
"hashed_secret": "30025f80f6e22cdafb85db387d50f90ea884576a",
"is_verified": false,
"line_number": 542
},
{
"type": "Base64 High Entropy String",
"filename": "templates/service-template.yml",
"hashed_secret": "355f24fd038bcaf85617abdcaa64af51ed19bbcf",
"is_verified": false,
"line_number": 542
},
{
"type": "Base64 High Entropy String",
"filename": "templates/service-template.yml",
"hashed_secret": "3d8a1dcd2c3c765ce35c9a9552d23273cc4ddace",
"is_verified": false,
"line_number": 542
},
{
"type": "Base64 High Entropy String",
"filename": "templates/service-template.yml",
"hashed_secret": "4ac7b0522761eba972467942cd5cd7499dd2c361",
"is_verified": false,
"line_number": 542
},
{
"type": "Base64 High Entropy String",
"filename": "templates/service-template.yml",
"hashed_secret": "7639ab2a6bcf2ea30a055a99468c9cd844d4c22a",
"is_verified": false,
"line_number": 542
},
{
"type": "Base64 High Entropy String",
"filename": "templates/service-template.yml",
"hashed_secret": "b56360daf4793d2a74991a972b34d95bc00fb2da",
"is_verified": false,
"line_number": 542
},
{
"type": "Base64 High Entropy String",
"filename": "templates/service-template.yml",
"hashed_secret": "c9a73ef9ee8ce9f38437227801c70bcc6740d1a1",
"is_verified": false,
"line_number": 542
},
{
"type": "Base64 High Entropy String",
"filename": "templates/service-template.yml",
"hashed_secret": "14736999d9940728c5294277831a702f7882dece",
"is_verified": false,
"line_number": 579
},
{
"type": "Secret Keyword",
"filename": "templates/service-template.yml",
"hashed_secret": "4e199b4a1c40b497a95fcd1cd896351733849949",
"is_verified": false,
"line_number": 666,
"is_secret": false
},
{
"type": "Secret Keyword",
"filename": "templates/service-template.yml",
"hashed_secret": "9d51dabe59aa776bef2909d3689374ebb93ab2be",
"is_verified": false,
"line_number": 710
}
],
"test/support/certs.json": [
{
"type": "Base64 High Entropy String",
"filename": "test/support/certs.json",
"hashed_secret": "99c4dce3baf838620dc33a9589cdca36d05b0be2",
"is_verified": false,
"line_number": 4
},
{
"type": "Base64 High Entropy String",
"filename": "test/support/certs.json",
Expand All @@ -330,5 +546,5 @@
}
]
},
"generated_at": "2022-12-15T17:48:26Z"
"generated_at": "2022-12-21T09:23:54Z"
}
2 changes: 1 addition & 1 deletion test/mocks/redhatsso.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ func (mockServer *redhatSSOMock) serviceAccountAuthMiddleware(next http.Handler)
return http.HandlerFunc(func(writer http.ResponseWriter, request *http.Request) {
clientID := request.FormValue("client_id")
clientSecret := request.FormValue("client_secret")

// pragma: allowlist nextline secret
if clientID == mockServer.initialClientID && mockServer.initialClientSecret == clientSecret {
next.ServeHTTP(writer, request)
return
Expand Down