Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROX-13456: Bump detect-secrets to 1.4.0 #679

Merged
merged 3 commits into from
Dec 21, 2022
Merged

ROX-13456: Bump detect-secrets to 1.4.0 #679

merged 3 commits into from
Dec 21, 2022

Conversation

kovayur
Copy link
Contributor

@kovayur kovayur commented Dec 15, 2022 •
edited
Loading

Description

Bump detect-secrets to 1.4.0

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Evaluated and added CHANGELOG.md entry if required
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.

Test manual

CI green

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

This was referenced Dec 15, 2022
Merged
Merged
@kovayur
Copy link
Contributor Author

kovayur commented Dec 15, 2022 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@kovayur kovayur mentioned this pull request Dec 15, 2022
Merged
7 tasks
@kovayur kovayur changed the title ROX-13456: Upgrade detect-secrets ROX-13456: Bump detect-secrets to 1.4.0 Dec 15, 2022
@kovayur kovayur force-pushed the yury/ROX-13456-refactor-fleet-manager-client branch from 3515f23 to be30b96 Compare December 15, 2022 15:36
@kovayur kovayur force-pushed the yury/ROX-13456-upgrade-detect-secrets branch 2 times, most recently from 695923a to 31122e4 Compare December 15, 2022 15:40
@kovayur kovayur marked this pull request as ready for review December 15, 2022 15:58
@kovayur kovayur requested review from dhaus67 and kurlov December 15, 2022 15:58
stehessel
stehessel reviewed Dec 19, 2022
View reviewed changes
.pre-commit-config.yaml
@@ -10,11 +10,10 @@ repos:
stages: [push, manual]
files: '(openapi/.*|pkg/workers/worker_interface.go|pkg/client/ocm/id.go|pkg/client/aws/client.go|pkg/client/ocm/client.go|pkg/client/iam/client.go|pkg/services/authorization/authorization.go|pkg/services/sso/iam_service.go|pkg/client/redhatsso/client.go|pkg/auth/auth_agent_service.go|internal/dinosaur/pkg/services/observatorium_service.go|internal/dinosaur/pkg/services/cluster_placement_strategy.go|internal/dinosaur/pkg/services/cloud_providers.go|internal/dinosaur/pkg/services/clusters.go|internal/dinosaur/pkg/services/quota.go|internal/dinosaur/pkg/services/fleetshard_operator_addon.go|internal/dinosaur/pkg/services/quota_service_factory.go|internal/dinosaur/pkg/clusters/cluster_builder.go|internal/dinosaur/pkg/clusters/provider.go|internal/dinosaur/pkg/services/dinosaur.go)'
- repo: https://github.com/Yelp/detect-secrets
rev: v1.2.0
rev: v1.4.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be awesome to use dependabot for this, but sadly pre-commit is not supported by it yet :(

@openshift-ci openshift-ci bot added the lgtm label Dec 19, 2022
Base automatically changed from yury/ROX-13456-refactor-fleet-manager-client to main December 19, 2022 15:10
@kovayur kovayur force-pushed the yury/ROX-13456-upgrade-detect-secrets branch from 31122e4 to 514e83b Compare December 19, 2022 15:15
@openshift-ci openshift-ci bot removed the lgtm label Dec 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 19, 2022

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, stehessel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 19, 2022

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, stehessel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kovayur kovayur force-pushed the yury/ROX-13456-upgrade-detect-secrets branch 2 times, most recently from 3b08473 to a17331f Compare December 21, 2022 08:38
@kovayur
Copy link
Contributor Author

kovayur commented Dec 21, 2022

/retest

@kovayur kovayur force-pushed the yury/ROX-13456-upgrade-detect-secrets branch from 76a31f6 to 8bda2e7 Compare December 21, 2022 14:57
@kovayur kovayur temporarily deployed to development December 21, 2022 14:57 — with GitHub Actions Inactive
@kovayur kovayur temporarily deployed to development December 21, 2022 14:57 — with GitHub Actions Inactive
@kovayur kovayur merged commit a809e72 into main Dec 21, 2022
@kovayur kovayur deleted the yury/ROX-13456-upgrade-detect-secrets branch December 21, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stehessel stehessel stehessel approved these changes

@dhaus67 dhaus67 Awaiting requested review from dhaus67

@kurlov kurlov Awaiting requested review from kurlov

Assignees

@stehessel stehessel

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kovayur @stehessel