ROX-23251: Add metrics for email sender service #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
4 tasks
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3 tasks
kurlov
changed the title
kurlov
force-pushed
the
akurlov/ROX-23251_add_metrics_email_sender
branch
from
43bd808 to
ee38481
Compare
kurlov
force-pushed
the
akurlov/ROX-23251_add_base_email_sender_service
branch
from
ac73c2f to
b22fd66
Compare
Base automatically changed from
akurlov/ROX-23251_add_base_email_sender_service
to
main
April 19, 2024 07:01
johannes94
requested changes
Apr 22, 2024
johannes94
reviewed
Apr 22, 2024
kurlov
commented
Apr 23, 2024
| metricServer := metrics.NewMetricsServer(cfg.MetricsAddress) | ||
| go func() { | ||
| glog.Info("Creating metrics server...") | ||
| if err := metricServer.ListenAndServe(); !errors.Is(err, http.ErrServerClosed) { |
There was a problem hiding this comment.
Also added error filtering to avoid logging error on graceful shutdown like this one:
1 main.go:68] metrics server error: http: Server closed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johannes94, kurlov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist (Definition of Done)
Test manual- [ ] Documentation added if necessary (i.e. changes to dev setup, test execution, ...)ROX-12345: ...- [ ] Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.- [ ] Add secret to app-interface Vault or Secrets Manager if necessary- [ ] RDS changes were e2e tested manually- [ ] Check AWS limits are reasonable for changes provisioning new resources- [ ] (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environmentTest manual