Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-23251: Add base for email sender service #1754

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

kurlov
Copy link
Member

@kurlov kurlov commented Apr 10, 2024

Description

  • Add base for new service for sending email
  • add basic server
  • add config and HTTPS support
  • add graceful shutdown handler

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
    - [ ] Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
    - [ ] Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
    - [ ] Add secret to app-interface Vault or Secrets Manager if necessary
    - [ ] RDS changes were e2e tested manually
    - [ ] Check AWS limits are reasonable for changes provisioning new resources
    - [ ] (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
CLUSTER_ID=test go run emailsender/cmd/app/main.go

Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kurlov
Copy link
Member Author

kurlov commented Apr 10, 2024

@kurlov kurlov changed the title add base for email sender service ROX-23251: Add base for email sender service Apr 10, 2024
@kurlov kurlov marked this pull request as ready for review April 10, 2024 02:32
@kurlov
Copy link
Member Author

kurlov commented Apr 10, 2024

/retest

1 similar comment
@kurlov
Copy link
Member Author

kurlov commented Apr 10, 2024

/retest

@kurlov
Copy link
Member Author

kurlov commented Apr 10, 2024

/override ci/prow/e2e

Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

@kurlov: Overrode contexts on behalf of kurlov: ci/prow/e2e

In response to this:

/override ci/prow/e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kurlov kurlov requested a review from johannes94 April 10, 2024 12:46
Copy link
Contributor

@johannes94 johannes94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor things to simplify.

Also could you add makefile targets for this service, or will that be part of a future PR?

emailsender/cmd/app/main.go Outdated Show resolved Hide resolved
emailsender/cmd/app/main.go Outdated Show resolved Hide resolved
emailsender/cmd/app/main.go Outdated Show resolved Hide resolved
emailsender/cmd/app/main.go Show resolved Hide resolved
emailsender/cmd/app/main.go Outdated Show resolved Hide resolved
emailsender/config/config.go Outdated Show resolved Hide resolved
emailsender/config/config.go Outdated Show resolved Hide resolved
@kurlov kurlov force-pushed the akurlov/ROX-23251_add_base_email_sender_service branch from ac73c2f to b22fd66 Compare April 17, 2024 22:05
@kurlov kurlov requested a review from johannes94 April 17, 2024 22:06
@kurlov
Copy link
Member Author

kurlov commented Apr 17, 2024

/retest

@openshift-ci openshift-ci bot added the lgtm label Apr 19, 2024
Copy link
Contributor

openshift-ci bot commented Apr 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johannes94, kurlov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kurlov kurlov merged commit e62eb9f into main Apr 19, 2024
8 checks passed
@kurlov kurlov deleted the akurlov/ROX-23251_add_base_email_sender_service branch April 19, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants