-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-23251: Add base for email sender service #1754
Conversation
Skipping CI for Draft Pull Request. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
/retest |
1 similar comment
/retest |
/override ci/prow/e2e |
@kurlov: Overrode contexts on behalf of kurlov: ci/prow/e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some minor things to simplify.
Also could you add makefile targets for this service, or will that be part of a future PR?
ac73c2f
to
b22fd66
Compare
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johannes94, kurlov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Checklist (Definition of Done)
Test manual
- [ ] Documentation added if necessary (i.e. changes to dev setup, test execution, ...)ROX-12345: ...
- [ ] Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.- [ ] Add secret to app-interface Vault or Secrets Manager if necessary- [ ] RDS changes were e2e tested manually- [ ] Check AWS limits are reasonable for changes provisioning new resources- [ ] (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environmentTest manual
TODO: Add manual testing efforts