-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-21070: Implement the addon mgmt in fleet manager #1522
Conversation
Skipping CI for Draft Pull Request. |
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
65db6ca
to
b073eda
Compare
701d573
to
5677063
Compare
b073eda
to
23c5cbf
Compare
if addonErr != nil { | ||
if addonErr.Is404() { | ||
// addon does not exist, install it | ||
multiErr = multierror.Append(multiErr, p.installAddon(clusterID, addon)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with multierror
, but should this read?
if err := p.installAddon(clusterID, addon)); err != nil {
multiErr = multierror.Append(multiErr, err)
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, in my case when err is nil there'll be no action. I fixed the logging a bit to support the error case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spotless! 💯
82a0c50
to
dc46791
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kovayur, ludydoo, SimonBaeumer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dc46791
to
cfa9be2
Compare
New changes are detected. LGTM label has been removed. |
Description
Install addon from Fleet Manager: Part 4.
This change adds a feature to automatically update addons from Fleet Manager.
Checklist (Definition of Done)
Test manual
ROX-12345: ...
Test manual
TODO: Add manual testing efforts