ROX-21070: Add fleetshard addon installation status to private api

[kovayur]

Description

Install addon from Fleet Manager: Part 1.
This change adds a new field called Addons to the Cluster object to track the actual state of addon installations on the data plane.
This change includes:

1. DB migration
2. Private API change
3. Conversion layer from the Private API to DB.
4. Integration tests

Checklist (Definition of Done)

• Unit and integration tests added
• Added test description under Test manual
• Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
• CI and all relevant tests are passing
• Add the ticket number to the PR title if available, i.e. ROX-12345: ...
• Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
• Add secret to app-interface Vault or Secrets Manager if necessary
• RDS changes were e2e tested manually
• Check AWS limits are reasonable for changes provisioning new resources

Test manual

Integration + E2E tests

[kovayur]

Current dependencies on/for this PR:

• main
  • PR ROX-21070: Add fleetshard addon installation status to private api #1503 👈
    • PR ROX-21070: Publish addon state from fleetshard-sync #1504
      • PR ROX-21070: Declare Data Plane Cluster configuration in gitops config #1521
        • PR ROX-21070: Implement the addon mgmt in fleet manager #1522
          • PR ROX-21070: Set fleetshard sync image from Fleet Manager #1531
            • PR ROX-21070: Make addon version optional #1570

This stack of pull requests is managed by Graphite.

[ebensh]

LGTM, thanks for the cleanups as well

[ebensh]

I was surprised to see that ctx could just be removed here - digging down it looks like the clusterService in clusters.go doesn't use gorm's support for context (https://gorm.io/docs/context.html), so piping it down doesn't make sense. But do you know, is there a reason why there's no use of the context down at the database level? Is that best practice to not try to interrupt database calls with context / maybe there's some bad interaction between them?

[kovayur]

I agree with your point @ebensh, but the scope of refactoring could be large, it looks like context is not used in clusters.go at all. I've created ROX-21492 to follow-up

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ebensh, kovayur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ebensh,kovayur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment