Fix precommit for flag fitops #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonBaeumer
approved these changes
Oct 13, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kurlov, SimonBaeumer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…it-for-flag-fitops
|
New changes are detected. LGTM label has been removed. |
SimonBaeumer
added a commit
that referenced
this pull request
Oct 17, 2023
WIP WIP fix varaible fix env vars Update e2e.sh (#1355) Update e2e.sh Improve logging in dev scripts (#1354) Update GitHub handle in OWNERS file (#1353) * Update GitHub handle Co-authored-by: Moritz Clasmeier <[email protected]> remove RHACS_STANDALONE var Update e2e.sh Fix precommit for flag fitops (#1358) Fix pre-commit Fix operator versions and pray that it works Fix gitops and fail early. Please pass Try to fix e2e tests push changes Fix tests Fix tests Skip upgrade test Add global image pull secrets create image pull secret WIP Increase memory limits explicit config for canary e2e & derease polling WIP
SimonBaeumer
added a commit
that referenced
this pull request
Oct 17, 2023
WIP WIP fix varaible fix env vars Update e2e.sh (#1355) Update e2e.sh Improve logging in dev scripts (#1354) Update GitHub handle in OWNERS file (#1353) * Update GitHub handle Co-authored-by: Moritz Clasmeier <[email protected]> remove RHACS_STANDALONE var Update e2e.sh Fix precommit for flag fitops (#1358) Fix pre-commit Fix operator versions and pray that it works Fix gitops and fail early. Please pass Try to fix e2e tests push changes Fix tests Fix tests Skip upgrade test Add global image pull secrets create image pull secret WIP Increase memory limits explicit config for canary e2e & derease polling WIP
ludydoo
pushed a commit
that referenced
this pull request
Oct 20, 2023
WIP WIP fix varaible fix env vars Update e2e.sh (#1355) Update e2e.sh Improve logging in dev scripts (#1354) Update GitHub handle in OWNERS file (#1353) * Update GitHub handle Co-authored-by: Moritz Clasmeier <[email protected]> remove RHACS_STANDALONE var Update e2e.sh Fix precommit for flag fitops (#1358) Fix pre-commit Fix operator versions and pray that it works Fix gitops and fail early. Please pass Try to fix e2e tests push changes Fix tests Fix tests Skip upgrade test Add global image pull secrets create image pull secret WIP Increase memory limits explicit config for canary e2e & derease polling WIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FIx pre-commit complain