Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging in dev scripts #1354

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Improve logging in dev scripts #1354

merged 3 commits into from
Oct 13, 2023

Conversation

ludydoo
Copy link
Collaborator

@ludydoo ludydoo commented Oct 13, 2023

No description provided.

@ludydoo ludydoo temporarily deployed to development October 13, 2023 11:26 — with GitHub Actions Inactive
@ludydoo ludydoo temporarily deployed to development October 13, 2023 11:26 — with GitHub Actions Inactive
@ludydoo ludydoo temporarily deployed to development October 13, 2023 11:26 — with GitHub Actions Inactive
@@ -4,13 +4,16 @@ GITROOT="$(git rev-parse --show-toplevel)"
export GITROOT
# shellcheck source=/dev/null
source "${GITROOT}/dev/env/scripts/lib.sh"
init
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already called by bootstrap.sh

@@ -6,7 +6,6 @@ GITROOT="$(git rev-parse --show-toplevel)"
export GITROOT
# shellcheck source=/dev/null
source "${GITROOT}/dev/env/scripts/lib.sh"
init
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is already called beforehand

@@ -6,7 +6,6 @@ GITROOT="$(git rev-parse --show-toplevel)"
export GITROOT
# shellcheck source=/dev/null
source "${GITROOT}/dev/env/scripts/lib.sh"
init
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already called beforehand

@@ -7,8 +7,6 @@ source "${GITROOT}/dev/env/scripts/lib.sh"
# shellcheck source=/dev/null
source "${GITROOT}/dev/env/scripts/docker.sh"

init
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already called before by bootstrap.sh

fi

log "Installing operator"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad indentation

@openshift-ci openshift-ci bot removed the lgtm label Oct 13, 2023
@ludydoo ludydoo temporarily deployed to development October 13, 2023 11:42 — with GitHub Actions Inactive
@ludydoo ludydoo temporarily deployed to development October 13, 2023 11:42 — with GitHub Actions Inactive
@ludydoo ludydoo temporarily deployed to development October 13, 2023 11:42 — with GitHub Actions Inactive
@ludydoo ludydoo temporarily deployed to development October 13, 2023 11:42 — with GitHub Actions Inactive
@ludydoo ludydoo temporarily deployed to development October 13, 2023 11:42 — with GitHub Actions Inactive
@ludydoo ludydoo temporarily deployed to development October 13, 2023 11:42 — with GitHub Actions Inactive
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kurlov, ludydoo, SimonBaeumer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SimonBaeumer,kurlov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ludydoo ludydoo merged commit 8e8de1a into main Oct 13, 2023
5 checks passed
@ludydoo ludydoo deleted the improve-fm-script-logging branch October 13, 2023 12:30
SimonBaeumer added a commit that referenced this pull request Oct 17, 2023
WIP

WIP

fix varaible

fix env vars

Update e2e.sh (#1355)

Update e2e.sh

Improve logging in dev scripts (#1354)

Update GitHub handle in OWNERS file (#1353)

* Update GitHub handle

Co-authored-by: Moritz Clasmeier <[email protected]>

remove RHACS_STANDALONE var

Update e2e.sh

Fix precommit for flag fitops (#1358)

Fix pre-commit

Fix operator versions and pray that it works

Fix gitops and fail early. Please pass

Try to fix e2e tests

push changes

Fix tests

Fix tests

Skip upgrade test

Add global image pull secrets

create image pull secret

WIP

Increase memory limits

explicit config for canary e2e & derease polling

WIP
SimonBaeumer added a commit that referenced this pull request Oct 17, 2023
WIP

WIP

fix varaible

fix env vars

Update e2e.sh (#1355)

Update e2e.sh

Improve logging in dev scripts (#1354)

Update GitHub handle in OWNERS file (#1353)

* Update GitHub handle

Co-authored-by: Moritz Clasmeier <[email protected]>

remove RHACS_STANDALONE var

Update e2e.sh

Fix precommit for flag fitops (#1358)

Fix pre-commit

Fix operator versions and pray that it works

Fix gitops and fail early. Please pass

Try to fix e2e tests

push changes

Fix tests

Fix tests

Skip upgrade test

Add global image pull secrets

create image pull secret

WIP

Increase memory limits

explicit config for canary e2e & derease polling

WIP
ludydoo pushed a commit that referenced this pull request Oct 20, 2023
WIP

WIP

fix varaible

fix env vars

Update e2e.sh (#1355)

Update e2e.sh

Improve logging in dev scripts (#1354)

Update GitHub handle in OWNERS file (#1353)

* Update GitHub handle

Co-authored-by: Moritz Clasmeier <[email protected]>

remove RHACS_STANDALONE var

Update e2e.sh

Fix precommit for flag fitops (#1358)

Fix pre-commit

Fix operator versions and pray that it works

Fix gitops and fail early. Please pass

Try to fix e2e tests

push changes

Fix tests

Fix tests

Skip upgrade test

Add global image pull secrets

create image pull secret

WIP

Increase memory limits

explicit config for canary e2e & derease polling

WIP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants