-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve logging in dev scripts #1354
Conversation
@@ -4,13 +4,16 @@ GITROOT="$(git rev-parse --show-toplevel)" | |||
export GITROOT | |||
# shellcheck source=/dev/null | |||
source "${GITROOT}/dev/env/scripts/lib.sh" | |||
init |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already called by bootstrap.sh
@@ -6,7 +6,6 @@ GITROOT="$(git rev-parse --show-toplevel)" | |||
export GITROOT | |||
# shellcheck source=/dev/null | |||
source "${GITROOT}/dev/env/scripts/lib.sh" | |||
init |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is already called beforehand
@@ -6,7 +6,6 @@ GITROOT="$(git rev-parse --show-toplevel)" | |||
export GITROOT | |||
# shellcheck source=/dev/null | |||
source "${GITROOT}/dev/env/scripts/lib.sh" | |||
init |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already called beforehand
@@ -7,8 +7,6 @@ source "${GITROOT}/dev/env/scripts/lib.sh" | |||
# shellcheck source=/dev/null | |||
source "${GITROOT}/dev/env/scripts/docker.sh" | |||
|
|||
init |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
already called before by bootstrap.sh
fi | ||
|
||
log "Installing operator" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bad indentation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kurlov, ludydoo, SimonBaeumer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
WIP WIP fix varaible fix env vars Update e2e.sh (#1355) Update e2e.sh Improve logging in dev scripts (#1354) Update GitHub handle in OWNERS file (#1353) * Update GitHub handle Co-authored-by: Moritz Clasmeier <[email protected]> remove RHACS_STANDALONE var Update e2e.sh Fix precommit for flag fitops (#1358) Fix pre-commit Fix operator versions and pray that it works Fix gitops and fail early. Please pass Try to fix e2e tests push changes Fix tests Fix tests Skip upgrade test Add global image pull secrets create image pull secret WIP Increase memory limits explicit config for canary e2e & derease polling WIP
WIP WIP fix varaible fix env vars Update e2e.sh (#1355) Update e2e.sh Improve logging in dev scripts (#1354) Update GitHub handle in OWNERS file (#1353) * Update GitHub handle Co-authored-by: Moritz Clasmeier <[email protected]> remove RHACS_STANDALONE var Update e2e.sh Fix precommit for flag fitops (#1358) Fix pre-commit Fix operator versions and pray that it works Fix gitops and fail early. Please pass Try to fix e2e tests push changes Fix tests Fix tests Skip upgrade test Add global image pull secrets create image pull secret WIP Increase memory limits explicit config for canary e2e & derease polling WIP
WIP WIP fix varaible fix env vars Update e2e.sh (#1355) Update e2e.sh Improve logging in dev scripts (#1354) Update GitHub handle in OWNERS file (#1353) * Update GitHub handle Co-authored-by: Moritz Clasmeier <[email protected]> remove RHACS_STANDALONE var Update e2e.sh Fix precommit for flag fitops (#1358) Fix pre-commit Fix operator versions and pray that it works Fix gitops and fail early. Please pass Try to fix e2e tests push changes Fix tests Fix tests Skip upgrade test Add global image pull secrets create image pull secret WIP Increase memory limits explicit config for canary e2e & derease polling WIP
No description provided.